diff mbox series

board_f: cosmetic: change the debug trace to KB in reserve_video

Message ID 20210409180126.1.I120ba9a4276e42538cae6f1f1aac51221c63f6ad@changeid
State Accepted
Commit 83064c27063dbc969477eda6a924f1418dc63991
Delegated to: Anatolij Gustschin
Headers show
Series board_f: cosmetic: change the debug trace to KB in reserve_video | expand

Commit Message

Patrick DELAUNAY April 9, 2021, 4:02 p.m. UTC
Update the debug trace for the reserved video memory to KB as indicated
in the message with "%luk"; before the patch the computed size
gd->relocaddr - addr is in bytes.

This patch aligns the debug trace in reserve_video() with others
functions, for example on stm32mp157c-dk2:

  - Reserving 3080192k for video at: dfd00000
  + Reserving 3008k for video at: dfd00000
    Reserving 873k for U-Boot at: dfc25000
    Reserving 32776k for malloc() at: ddc23000
    Reserving 72 Bytes for Board Info at: ddc22fb0
    Reserving 280 Bytes for Global Data at: ddc22e90
    Reserving 119072 Bytes for FDT at: ddc05d70
    Reserving 0x278 Bytes for bootstage at: ddc05af0

Fixes: 5630d2fbc50f3035 ("board: Show memory for frame buffers")
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 common/board_f.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass April 9, 2021, 8:58 p.m. UTC | #1
On Sat, 10 Apr 2021 at 04:02, Patrick Delaunay
<patrick.delaunay@foss.st.com> wrote:
>
> Update the debug trace for the reserved video memory to KB as indicated
> in the message with "%luk"; before the patch the computed size
> gd->relocaddr - addr is in bytes.
>
> This patch aligns the debug trace in reserve_video() with others
> functions, for example on stm32mp157c-dk2:
>
>   - Reserving 3080192k for video at: dfd00000
>   + Reserving 3008k for video at: dfd00000
>     Reserving 873k for U-Boot at: dfc25000
>     Reserving 32776k for malloc() at: ddc23000
>     Reserving 72 Bytes for Board Info at: ddc22fb0
>     Reserving 280 Bytes for Global Data at: ddc22e90
>     Reserving 119072 Bytes for FDT at: ddc05d70
>     Reserving 0x278 Bytes for bootstage at: ddc05af0
>
> Fixes: 5630d2fbc50f3035 ("board: Show memory for frame buffers")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
>  common/board_f.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Anatolij Gustschin April 11, 2021, 7:10 p.m. UTC | #2
On Fri, 9 Apr 2021 18:02:06 +0200
Patrick Delaunay patrick.delaunay@foss.st.com wrote:
...
> Fixes: 5630d2fbc50f3035 ("board: Show memory for frame buffers")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  common/board_f.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-video/master, thanks!

--
Anatolij
diff mbox series

Patch

diff --git a/common/board_f.c b/common/board_f.c
index 0cddf0359d..203e965799 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -394,7 +394,7 @@  static int reserve_video(void)
 	if (ret)
 		return ret;
 	debug("Reserving %luk for video at: %08lx\n",
-	      (unsigned long)gd->relocaddr - addr, addr);
+	      ((unsigned long)gd->relocaddr - addr) >> 10, addr);
 	gd->relocaddr = addr;
 #elif defined(CONFIG_LCD)
 #  ifdef CONFIG_FB_ADDR