diff mbox series

[v4,21/22] ppc: qemu: Enable eTSEC support

Message ID 20210314121506.18303-22-bmeng.cn@gmail.com
State Accepted
Commit f6e95afc0d9ca0043d54b732d8bf6a14d89105c9
Delegated to: Priyanka Jain
Headers show
Series ppc: qemu: Add eTSEC support | expand

Commit Message

Bin Meng March 14, 2021, 12:15 p.m. UTC 
QEMU ppce500 target can dynamically instantiate an eTSEC device
if "-device eTSEC" is given to QEMU. This commit enables eTSEC
driver and the required fixed PHY driver to create a usable
network configuration using eTSEC.

Unlike a real world 85xx board that usually stores the eTSEC MAC
address in an EEPROM, CONFIG_NET_RANDOM_ETHADDR is required for
QEMU otherwise U-Boot ethernet initialization complains no valid
ethernet address is set.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---

(no changes since v1)

 configs/qemu-ppce500_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Priyanka Jain April 14, 2021, 11:54 a.m. UTC | #1 
>-----Original Message-----
>From: Bin Meng <bmeng.cn@gmail.com>
>Sent: Sunday, March 14, 2021 5:45 PM
>To: Priyanka Jain <priyanka.jain@nxp.com>; Ramon Fried
><rfried.dev@gmail.com>; Simon Glass <sjg@chromium.org>; u-
>boot@lists.denx.de
>Cc: Tom Rini <trini@konsulko.com>; Vladimir Oltean <vladimir.oltean@nxp.com>;
>Bin Meng <bmeng.cn@gmail.com>
>Subject: [PATCH v4 21/22] ppc: qemu: Enable eTSEC support
>
>QEMU ppce500 target can dynamically instantiate an eTSEC device if "-device
>eTSEC" is given to QEMU. This commit enables eTSEC driver and the required
>fixed PHY driver to create a usable network configuration using eTSEC.
>
>Unlike a real world 85xx board that usually stores the eTSEC MAC address in an
>EEPROM, CONFIG_NET_RANDOM_ETHADDR is required for QEMU otherwise U-
>Boot ethernet initialization complains no valid ethernet address is set.
>
>Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>---
>
>(no changes since v1)
>
> configs/qemu-ppce500_defconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/configs/qemu-ppce500_defconfig b/configs/qemu-ppce500_defconfig
>index 151834b4cf..a1b9ea56ca 100644
>--- a/configs/qemu-ppce500_defconfig
>+++ b/configs/qemu-ppce500_defconfig
>@@ -27,6 +27,7 @@ CONFIG_OF_CONTROL=y
> CONFIG_OF_BOARD=y
> CONFIG_ENV_OVERWRITE=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>+CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_DM=y
> CONFIG_SIMPLE_BUS_CORRECT_RANGE=y
> CONFIG_BLK=y
>@@ -35,8 +36,11 @@ CONFIG_MPC8XXX_GPIO=y  CONFIG_DM_I2C=y
>CONFIG_SYS_I2C_FSL=y  # CONFIG_MMC is not set
>+CONFIG_PHY_FIXED=y
> CONFIG_DM_ETH=y
>+CONFIG_DM_MDIO=y
> CONFIG_E1000=y
>+CONFIG_TSEC_ENET=y
> CONFIG_DM_PCI=y
> CONFIG_PCI_MPC85XX=y
> CONFIG_DM_RTC=y
>--
>2.25.1

I tried integrating the series and was getting below error: 
2021-04-12T09:39:56.7536565Z FAILED test/py/tests/test_efi_selftest.py::test_efi_selftest - u_boot_spawn.T...
2021-04-12T09:39:56.7537048Z = 1 failed, 108 passed, 227 skipped, 1 deselected, 3 warnings in 65.61s (0:01:05) =

Details at https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/2112/logs/251

I reverted this patch and it then build fine .
https://github.com/u-boot/u-boot/pull/65

Kindly check.

Regards
Priyanka
Tom Rini April 14, 2021, 12:46 p.m. UTC | #2 
On Wed, Apr 14, 2021 at 11:54:39AM +0000, Priyanka Jain wrote:
> 
> 
> >-----Original Message-----
> >From: Bin Meng <bmeng.cn@gmail.com>
> >Sent: Sunday, March 14, 2021 5:45 PM
> >To: Priyanka Jain <priyanka.jain@nxp.com>; Ramon Fried
> ><rfried.dev@gmail.com>; Simon Glass <sjg@chromium.org>; u-
> >boot@lists.denx.de
> >Cc: Tom Rini <trini@konsulko.com>; Vladimir Oltean <vladimir.oltean@nxp.com>;
> >Bin Meng <bmeng.cn@gmail.com>
> >Subject: [PATCH v4 21/22] ppc: qemu: Enable eTSEC support
> >
> >QEMU ppce500 target can dynamically instantiate an eTSEC device if "-device
> >eTSEC" is given to QEMU. This commit enables eTSEC driver and the required
> >fixed PHY driver to create a usable network configuration using eTSEC.
> >
> >Unlike a real world 85xx board that usually stores the eTSEC MAC address in an
> >EEPROM, CONFIG_NET_RANDOM_ETHADDR is required for QEMU otherwise U-
> >Boot ethernet initialization complains no valid ethernet address is set.
> >
> >Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> >---
> >
> >(no changes since v1)
> >
> > configs/qemu-ppce500_defconfig | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/configs/qemu-ppce500_defconfig b/configs/qemu-ppce500_defconfig
> >index 151834b4cf..a1b9ea56ca 100644
> >--- a/configs/qemu-ppce500_defconfig
> >+++ b/configs/qemu-ppce500_defconfig
> >@@ -27,6 +27,7 @@ CONFIG_OF_CONTROL=y
> > CONFIG_OF_BOARD=y
> > CONFIG_ENV_OVERWRITE=y
> > CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> >+CONFIG_NET_RANDOM_ETHADDR=y
> > CONFIG_DM=y
> > CONFIG_SIMPLE_BUS_CORRECT_RANGE=y
> > CONFIG_BLK=y
> >@@ -35,8 +36,11 @@ CONFIG_MPC8XXX_GPIO=y  CONFIG_DM_I2C=y
> >CONFIG_SYS_I2C_FSL=y  # CONFIG_MMC is not set
> >+CONFIG_PHY_FIXED=y
> > CONFIG_DM_ETH=y
> >+CONFIG_DM_MDIO=y
> > CONFIG_E1000=y
> >+CONFIG_TSEC_ENET=y
> > CONFIG_DM_PCI=y
> > CONFIG_PCI_MPC85XX=y
> > CONFIG_DM_RTC=y
> >--
> >2.25.1
> 
> I tried integrating the series and was getting below error: 
> 2021-04-12T09:39:56.7536565Z FAILED test/py/tests/test_efi_selftest.py::test_efi_selftest - u_boot_spawn.T...
> 2021-04-12T09:39:56.7537048Z = 1 failed, 108 passed, 227 skipped, 1 deselected, 3 warnings in 65.61s (0:01:05) =
> 
> Details at https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/2112/logs/251
> 
> I reverted this patch and it then build fine .
> https://github.com/u-boot/u-boot/pull/65

Did this fail more than once in that job?  Sometimes due to I assume
some race/etc, that test will fail from time to time.
Bin Meng April 14, 2021, 1 p.m. UTC | #3 
Hi Priyanka,

On Wed, Apr 14, 2021 at 7:54 PM Priyanka Jain <priyanka.jain@nxp.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Bin Meng <bmeng.cn@gmail.com>
> >Sent: Sunday, March 14, 2021 5:45 PM
> >To: Priyanka Jain <priyanka.jain@nxp.com>; Ramon Fried
> ><rfried.dev@gmail.com>; Simon Glass <sjg@chromium.org>; u-
> >boot@lists.denx.de
> >Cc: Tom Rini <trini@konsulko.com>; Vladimir Oltean <vladimir.oltean@nxp.com>;
> >Bin Meng <bmeng.cn@gmail.com>
> >Subject: [PATCH v4 21/22] ppc: qemu: Enable eTSEC support
> >
> >QEMU ppce500 target can dynamically instantiate an eTSEC device if "-device
> >eTSEC" is given to QEMU. This commit enables eTSEC driver and the required
> >fixed PHY driver to create a usable network configuration using eTSEC.
> >
> >Unlike a real world 85xx board that usually stores the eTSEC MAC address in an
> >EEPROM, CONFIG_NET_RANDOM_ETHADDR is required for QEMU otherwise U-
> >Boot ethernet initialization complains no valid ethernet address is set.
> >
> >Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> >---
> >
> >(no changes since v1)
> >
> > configs/qemu-ppce500_defconfig | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/configs/qemu-ppce500_defconfig b/configs/qemu-ppce500_defconfig
> >index 151834b4cf..a1b9ea56ca 100644
> >--- a/configs/qemu-ppce500_defconfig
> >+++ b/configs/qemu-ppce500_defconfig
> >@@ -27,6 +27,7 @@ CONFIG_OF_CONTROL=y
> > CONFIG_OF_BOARD=y
> > CONFIG_ENV_OVERWRITE=y
> > CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> >+CONFIG_NET_RANDOM_ETHADDR=y
> > CONFIG_DM=y
> > CONFIG_SIMPLE_BUS_CORRECT_RANGE=y
> > CONFIG_BLK=y
> >@@ -35,8 +36,11 @@ CONFIG_MPC8XXX_GPIO=y  CONFIG_DM_I2C=y
> >CONFIG_SYS_I2C_FSL=y  # CONFIG_MMC is not set
> >+CONFIG_PHY_FIXED=y
> > CONFIG_DM_ETH=y
> >+CONFIG_DM_MDIO=y
> > CONFIG_E1000=y
> >+CONFIG_TSEC_ENET=y
> > CONFIG_DM_PCI=y
> > CONFIG_PCI_MPC85XX=y
> > CONFIG_DM_RTC=y
> >--
> >2.25.1
>
> I tried integrating the series and was getting below error:
> 2021-04-12T09:39:56.7536565Z FAILED test/py/tests/test_efi_selftest.py::test_efi_selftest - u_boot_spawn.T...
> 2021-04-12T09:39:56.7537048Z = 1 failed, 108 passed, 227 skipped, 1 deselected, 3 warnings in 65.61s (0:01:05) =
>
> Details at https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/2112/logs/251
>
> I reverted this patch and it then build fine .
> https://github.com/u-boot/u-boot/pull/65

As I mentioned in this series cover letter, Azure results were all PASS.

Please see:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=343&view=results

Regards,
Bin
diff mbox series

Patch

diff --git a/configs/qemu-ppce500_defconfig b/configs/qemu-ppce500_defconfig
index 151834b4cf..a1b9ea56ca 100644
--- a/configs/qemu-ppce500_defconfig
+++ b/configs/qemu-ppce500_defconfig
@@ -27,6 +27,7 @@  CONFIG_OF_CONTROL=y
 CONFIG_OF_BOARD=y
 CONFIG_ENV_OVERWRITE=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_SIMPLE_BUS_CORRECT_RANGE=y
 CONFIG_BLK=y
@@ -35,8 +36,11 @@  CONFIG_MPC8XXX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_FSL=y
 # CONFIG_MMC is not set
+CONFIG_PHY_FIXED=y
 CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
 CONFIG_E1000=y
+CONFIG_TSEC_ENET=y
 CONFIG_DM_PCI=y
 CONFIG_PCI_MPC85XX=y
 CONFIG_DM_RTC=y