diff mbox series

[07/19] video: sunxi: Remove check for ddc-i2c-bus property

Message ID 20210223204631.1609597-8-jernej.skrabec@siol.net
State New
Delegated to: Andre Przywara
Headers show
Series video: sunxi: Rework DE2 driver | expand

Commit Message

Jernej Škrabec Feb. 23, 2021, 8:46 p.m. UTC
No Allwinner boards with DW-HDMI controller use separate I2C bus for
EDID read. Remove that check.

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 drivers/video/sunxi/sunxi_dw_hdmi.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andre Przywara March 4, 2021, 1:42 a.m. UTC | #1
On Tue, 23 Feb 2021 21:46:19 +0100
Jernej Skrabec <jernej.skrabec@siol.net> wrote:

> No Allwinner boards with DW-HDMI controller use separate I2C bus for
> EDID read. Remove that check.

Apparently the Cubieboard 4 has (as the only Allwinner board I can
find in the dts directories), but that is not supported by this driver,
and possibly doesn't even have a DW controller.
 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  drivers/video/sunxi/sunxi_dw_hdmi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c b/drivers/video/sunxi/sunxi_dw_hdmi.c
> index 37e78ff24111..6d2bc206fc2c 100644
> --- a/drivers/video/sunxi/sunxi_dw_hdmi.c
> +++ b/drivers/video/sunxi/sunxi_dw_hdmi.c
> @@ -361,9 +361,6 @@ static int sunxi_dw_hdmi_probe(struct udevice *dev)
>  		return -1;
>  	}
>  
> -	uclass_get_device_by_phandle(UCLASS_I2C, dev, "ddc-i2c-bus",
> -				     &priv->hdmi.ddc_bus);
> -
>  	dw_hdmi_init(&priv->hdmi);
>  
>  	return 0;
Jernej Škrabec March 4, 2021, 7:41 p.m. UTC | #2
Hi!

Dne četrtek, 04. marec 2021 ob 02:42:21 CET je Andre Przywara napisal(a):
> On Tue, 23 Feb 2021 21:46:19 +0100
> Jernej Skrabec <jernej.skrabec@siol.net> wrote:
> 
> > No Allwinner boards with DW-HDMI controller use separate I2C bus for
> > EDID read. Remove that check.
> 
> Apparently the Cubieboard 4 has (as the only Allwinner board I can
> find in the dts directories), but that is not supported by this driver,
> and possibly doesn't even have a DW controller.

Cubieboard 4 uses this property for VGA. A80 really has DW-HDMI but it uses 
dedicated DDC lines.

Best regards,
Jernej

>  
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> 
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> 
> Cheers,
> Andre
> 
> > ---
> >  drivers/video/sunxi/sunxi_dw_hdmi.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c b/drivers/video/sunxi/
sunxi_dw_hdmi.c
> > index 37e78ff24111..6d2bc206fc2c 100644
> > --- a/drivers/video/sunxi/sunxi_dw_hdmi.c
> > +++ b/drivers/video/sunxi/sunxi_dw_hdmi.c
> > @@ -361,9 +361,6 @@ static int sunxi_dw_hdmi_probe(struct udevice *dev)
> >  		return -1;
> >  	}
> >  
> > -	uclass_get_device_by_phandle(UCLASS_I2C, dev, "ddc-i2c-bus",
> > -				     &priv->hdmi.ddc_bus);
> > -
> >  	dw_hdmi_init(&priv->hdmi);
> >  
> >  	return 0;
> 
>
diff mbox series

Patch

diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c b/drivers/video/sunxi/sunxi_dw_hdmi.c
index 37e78ff24111..6d2bc206fc2c 100644
--- a/drivers/video/sunxi/sunxi_dw_hdmi.c
+++ b/drivers/video/sunxi/sunxi_dw_hdmi.c
@@ -361,9 +361,6 @@  static int sunxi_dw_hdmi_probe(struct udevice *dev)
 		return -1;
 	}
 
-	uclass_get_device_by_phandle(UCLASS_I2C, dev, "ddc-i2c-bus",
-				     &priv->hdmi.ddc_bus);
-
 	dw_hdmi_init(&priv->hdmi);
 
 	return 0;