| Message ID | 20210219184520.616270-12-mr.nuke.me@gmail.com |
|---|---|
| State | Accepted |
| Commit | 78015263b9789ef12fa6e454cf5041f97ce40da4 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add support for ECDSA image signing | expand |
On Fri, 19 Feb 2021 at 11:45, Alexandru Gagniuc <mr.nuke.me@gmail.com> wrote: > > Originally, the ECDSA code path used 'keydir' as the key filename. > mkimage has since been updated to include a new 'keyfile' argument. > Use the new argument for passing in the key. > > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> > --- > test/py/tests/test_fit_ecdsa.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, Feb 19, 2021 at 12:45:20PM -0600, Alexandru Gagniuc wrote: > Originally, the ECDSA code path used 'keydir' as the key filename. > mkimage has since been updated to include a new 'keyfile' argument. > Use the new argument for passing in the key. > > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/test/py/tests/test_fit_ecdsa.py b/test/py/tests/test_fit_ecdsa.py index f597570281..87b6081222 100644 --- a/test/py/tests/test_fit_ecdsa.py +++ b/test/py/tests/test_fit_ecdsa.py @@ -52,7 +52,7 @@ class SignableFitImage(object): self.__fdt_set(f'{image}/signature', algo='sha256,ecdsa256') def sign(self, mkimage, key_file): - util.run_and_log(self.cons, [mkimage, '-F', self.fit, f'-k{key_file}']) + util.run_and_log(self.cons, [mkimage, '-F', self.fit, f'-G{key_file}']) def check_signatures(self, key): for image in self.signable_nodes:
Originally, the ECDSA code path used 'keydir' as the key filename. mkimage has since been updated to include a new 'keyfile' argument. Use the new argument for passing in the key. Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> --- test/py/tests/test_fit_ecdsa.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)