From patchwork Tue Feb 16 01:16:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 1440749 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=nM2m08d0; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dfjk64XLPz9sVR for ; Tue, 16 Feb 2021 12:17:02 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9AB558276C; Tue, 16 Feb 2021 02:16:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="nM2m08d0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7910F8274E; Tue, 16 Feb 2021 02:16:32 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D77AB826F2 for ; Tue, 16 Feb 2021 02:16:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20210216011620epoutp045683262d5e6c6d3a354d244642927bc2~kFXodAFrb0438204382epoutp04e for ; Tue, 16 Feb 2021 01:16:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20210216011620epoutp045683262d5e6c6d3a354d244642927bc2~kFXodAFrb0438204382epoutp04e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1613438180; bh=kTtFR6HxMNnG1LNf2ksk6ULj4QST0hpXrkVteZCqXMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nM2m08d0x6G5GCqsqt3Vp04NKCPZf6hj9YQuCVGczEySX3qSjZo6kNcMqHxN+NlVW D1cqkddFt7yQt+LIhwkxagVzt5pYEdEEQfFH/6m/SfLFXP5p+pn8sq9T1i1PBGZAYY V2wT05EaPf2YR7N7KJUeoNGipuuqUhkuSmcf9UxM= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20210216011620epcas1p4736230bd994dcddb213b4518307b199e~kFXoK7UqJ1971319713epcas1p4F; Tue, 16 Feb 2021 01:16:20 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.40.157]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4DfjjF4yqlz4x9Py; Tue, 16 Feb 2021 01:16:17 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 9F.E2.09582.1EC1B206; Tue, 16 Feb 2021 10:16:17 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20210216011616epcas1p2c19ad33dd33933d949bcbc34288fc22a~kFXk8sTlH3106031060epcas1p21; Tue, 16 Feb 2021 01:16:16 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20210216011616epsmtrp159e15950b0adb654476488f2af761a7b~kFXk7xOA33239132391epsmtrp1B; Tue, 16 Feb 2021 01:16:16 +0000 (GMT) X-AuditID: b6c32a37-8afff7000000256e-8c-602b1ce18479 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 41.75.08745.0EC1B206; Tue, 16 Feb 2021 10:16:16 +0900 (KST) Received: from jaehoon-DeskTop.10.32.193.11 (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20210216011616epsmtip18073048fcf619609b1b6e3c4afc17ce2~kFXktl3Z73101831018epsmtip1y; Tue, 16 Feb 2021 01:16:16 +0000 (GMT) From: Jaehoon Chung To: u-boot@lists.denx.de Cc: u-boot-amlogic@groups.io, narmstrong@baylibre.com, sjg@chromium.org, peng.fan@nxp.com, kever.yang@rock-chips.com, philipp.tomsich@theobroma-systems.com, Jaehoon Chung Subject: [PATCH V2 3/5] mmc: rockchip_dw_mmc: use mmc_pwrseq instead of rockchip_mmc_pwrseq Date: Tue, 16 Feb 2021 10:16:54 +0900 Message-Id: <20210216011656.12855-4-jh80.chung@samsung.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210216011656.12855-1-jh80.chung@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIJsWRmVeSWpSXmKPExsWy7bCmru5DGe0Eg0MrVCxu/Gpjtdg2/Seb xaG+aIsfq76wWny50cpq8W3LNkaLSRN+sVm83dvJ7sDh8f5GK7vH7IaLLB7zO78zeZy9s4PR Y+O7HUwef2ftZ/Ho27KK0WPtow0sARxR2TYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqG lhbmSgp5ibmptkouPgG6bpk5QKcpKZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVUgtScgos C/SKE3OLS/PS9ZLzc60MDQyMTIEKE7Izru89xVawQqji2ZJOxgbG9fxdjJwcEgImEpt3dTF1 MXJxCAnsYJSY962FGcL5xCixf/ZJdgjnM1Cmq4UVpmXyqgWMILaQwC5GieaNMhBFvxklLq0+ BJZgE9CR2P7tOBOILSIgIfGr/ypYnFngJKPEi+nKILawQKzE1M5bbCA2i4CqxOoZ01lAbF4B a4kdszcyQyyTl/hzvwfM5hSwkbg2dREzRI2gxMmZT1ggZspLNG+dDXa2hEArh8T8O7/YIZpd JLa+uMsEYQtLvDq+BSouJfGyvw3KrpbY1XwGqrmDUeLWtiaoBmOJ/UsnA9kcQBs0Jdbv0ocI K0rs/D0X6hk+iXdfe1hBSiQEeCU62oQgSlQkLr1+yQSz6u6T/9CA85C4/rcNGtb9jBL9Fw6w TGBUmIXkn1lI/pmFsHkBI/MqRrHUguLc9NRiwwJj5CjexAhOq1rmOxinvf2gd4iRiYPxEKME B7OSCC/7Z60EId6UxMqq1KL8+KLSnNTiQ4ymwNCeyCwlmpwPTOx5JfGGpkbGxsYWJoZmpoaG SuK8SQYP4oUE0hNLUrNTUwtSi2D6mDg4pRqYoo70OV/O917Pxsh8f6HrlPoQvqkbTu5fNrdX 5FXGhvTFB9n3q514dtz6qp/eaeYpt7WsFxvO7NURCNkWcPowq+r2C8dnZE3bOsm85Fua/o0u oWd6NzbKq22b/3Ldct0rTenZFfcbk6z/c0bYxPUKPv5xm1kr71Obnz/P7+o1Zbcs/TkdU3TY LZotpF89YDDYsd5nauH2bkmVmPVP+LSsRS/efBgj8/DTzlNdnmmc4ZYz0xPXq//7NP/jhcfz pzifPRo3s33a3G597Z5k48UXOKXfNMcln1r9+ttBO47ixqPtbDM//ysq6Hi9//oHfuaOaKGb qQ6THh8XZmjKPRQX45E55R+T2LXD2evqNFWWKrEUZyQaajEXFScCAN7RLsg0BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsWy7bCSnO4DGe0Eg9MbjSxu/Gpjtdg2/Seb xaG+aIsfq76wWny50cpq8W3LNkaLSRN+sVm83dvJ7sDh8f5GK7vH7IaLLB7zO78zeZy9s4PR Y+O7HUwef2ftZ/Ho27KK0WPtow0sARxRXDYpqTmZZalF+nYJXBnX955iK1ghVPFsSSdjA+N6 /i5GTg4JAROJyasWMHYxcnEICexglLi/6RELREJK4vPTqWxdjBxAtrDE4cPFEDU/GSWm7L/O ClLDJqAjsf3bcSYQW0RAQuJX/1WwQcwC5xklDrx9CjZIWCBaYvHL1YwgNouAqsTqGdPB4rwC 1hI7Zm9khlgmL/Hnfg+YzSlgI3Ft6iIwWwioZtG0TYwQ9YISJ2c+AetlBqpv3jqbeQKjwCwk qVlIUgsYmVYxSqYWFOem5xYbFhjlpZbrFSfmFpfmpesl5+duYgSHv5bWDsY9qz7oHWJk4mA8 xCjBwawkwsv+WStBiDclsbIqtSg/vqg0J7X4EKM0B4uSOO+FrpPxQgLpiSWp2ampBalFMFkm Dk6pBiZr26sNbku+GjkGVvzd+CfVP+os83FxK85J1gK/2WxfZZfXvfQ8fo2ZZ9qGes4DlRcb zQ1nmjNVhF3gTlj6XFMioiNrr4z9D7XZOu07ZP8dDxctmzJzYbh1eMYntTz/Wco5P6dWTtZY /aJ0a8SvV6/r5i+aopnlnR2g3rHq1zX77xNji2S8PqRaeGucn1Zyga/5//L974z/bHFd6fjJ S3qHuY9Vf9iZrGenMmxSZLgvOEo0Z36a0ClQMIm18NPVzdPDAhyuhPCySaXf9fWcnGGn3u76 UWtC9mXpDr1fr8/fYtCI+lLQ7KTiU5K2+env8oLIyw+L3rqxZP40/6D8XeOqZMTiyxolOy0E 9v7UVGIpzkg01GIuKk4EAO5WM8DuAgAA X-CMS-MailID: 20210216011616epcas1p2c19ad33dd33933d949bcbc34288fc22a X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210216011616epcas1p2c19ad33dd33933d949bcbc34288fc22a References: <20210216011656.12855-1-jh80.chung@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Use mmc_pwrseq instead of rockchip_mmc_pwrseq. Signed-off-by: Jaehoon Chung --- Changelog on V2: - Remove unused variable - Fix build error --- drivers/mmc/rockchip_dw_mmc.c | 42 +++-------------------------------- 1 file changed, 3 insertions(+), 39 deletions(-) diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c index 1be3c1741fd4..36a00bb2bf55 100644 --- a/drivers/mmc/rockchip_dw_mmc.c +++ b/drivers/mmc/rockchip_dw_mmc.c @@ -105,7 +105,6 @@ static int rockchip_dwmmc_probe(struct udevice *dev) struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev); struct rockchip_dwmmc_priv *priv = dev_get_priv(dev); struct dwmci_host *host = &priv->host; - struct udevice *pwr_dev __maybe_unused; int ret; #if CONFIG_IS_ENABLED(OF_PLATDATA) @@ -136,12 +135,11 @@ static int rockchip_dwmmc_probe(struct udevice *dev) host->fifo_mode = priv->fifo_mode; -#ifdef CONFIG_PWRSEQ +#ifdef CONFIG_MMC_PWRSEQ /* Enable power if needed */ - ret = uclass_get_device_by_phandle(UCLASS_PWRSEQ, dev, "mmc-pwrseq", - &pwr_dev); + ret = mmc_pwrseq_get_power(dev, &plat->cfg); if (!ret) { - ret = pwrseq_set_power(pwr_dev, true); + ret = pwrseq_set_power(plat->cfg.pwr_dev, true); if (ret) return ret; } @@ -182,37 +180,3 @@ U_BOOT_DRIVER(rockchip_rk3288_dw_mshc) = { DM_DRIVER_ALIAS(rockchip_rk3288_dw_mshc, rockchip_rk3328_dw_mshc) DM_DRIVER_ALIAS(rockchip_rk3288_dw_mshc, rockchip_rk3368_dw_mshc) - -#ifdef CONFIG_PWRSEQ -static int rockchip_dwmmc_pwrseq_set_power(struct udevice *dev, bool enable) -{ - struct gpio_desc reset; - int ret; - - ret = gpio_request_by_name(dev, "reset-gpios", 0, &reset, GPIOD_IS_OUT); - if (ret) - return ret; - dm_gpio_set_value(&reset, 1); - udelay(1); - dm_gpio_set_value(&reset, 0); - udelay(200); - - return 0; -} - -static const struct pwrseq_ops rockchip_dwmmc_pwrseq_ops = { - .set_power = rockchip_dwmmc_pwrseq_set_power, -}; - -static const struct udevice_id rockchip_dwmmc_pwrseq_ids[] = { - { .compatible = "mmc-pwrseq-emmc" }, - { } -}; - -U_BOOT_DRIVER(rockchip_dwmmc_pwrseq_drv) = { - .name = "mmc_pwrseq_emmc", - .id = UCLASS_PWRSEQ, - .of_match = rockchip_dwmmc_pwrseq_ids, - .ops = &rockchip_dwmmc_pwrseq_ops, -}; -#endif