Message ID | 20210128094041.26319-17-biwen.li@oss.nxp.com |
---|---|
State | Superseded |
Delegated to: | Priyanka Jain |
Headers | show |
Series | gpio: layerscape: fix gpio and enable gpio | expand |
>-----Original Message----- >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Biwen Li >Sent: Thursday, January 28, 2021 3:10 PM >To: Priyanka Jain <priyanka.jain@nxp.com> >Cc: Jiafei Pan <jiafei.pan@nxp.com>; u-boot@lists.denx.de; Xiaobo Xie ><xiaobo.xie@nxp.com>; Biwen Li <biwen.li@nxp.com> >Subject: [v3 16/33] configs: ls1021atwr: enable CONFIG_MPC8XXX_GPIO > >From: Biwen Li <biwen.li@nxp.com> > >Enable CONFIG_MPC8XXX_GPIO for board ls1021atwr > >Signed-off-by: Biwen Li <biwen.li@nxp.com> >--- <snip> Kindly fix below build error for ls1021atwr platforms +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: In function â mpc8xxx_gpio_get_valâ : +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:50:29: error: dereferencing pointer to incomplete type â struct ccsr_gpioâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) return in_le32(&data->base->gpdat) & mask; +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../include/linux/byteorder/little_endian.h:35:51: note: in definition of macro â __le32_to_cpuâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../arch/arm/include/asm/io.h:105:25: note: in expansion of macro â __arch_getlâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define __raw_readl(a) __arch_getl(a) +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^~~~~~~~~~~ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../arch/arm/include/asm/io.h:173:49: note: in expansion of macro â __raw_readlâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define in_arch(type,endian,a) endian##_to_cpu(__raw_read##type(a)) +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^~~~~~~~~~ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../arch/arm/include/asm/io.h:180:20: note: in expansion of macro â in_archâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define in_le32(a) in_arch(l,le32,a) +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^~~~~~~ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:50:10: note: in expansion of macro â in_le32â +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^~~~~~~ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: In function â mpc8xxx_gpio_of_to_platâ : +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:184:6: error: dereferencing pointer to incomplete type â struct mpc8xxx_gpio_platâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) plat->addr = (ulong)dev_read_addr_size_index(dev, 0, (fdt_size_t *)&plat->size); +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^~ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: In function â mpc8xxx_gpio_plat_to_privâ : +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:195:27: error: dereferencing pointer to incomplete type â struct mpc8xxx_gpio_platâ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) unsigned long size = plat->size; +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ^~ +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: At top level: Regards Priyanka
> -----Original Message----- > From: Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com> > Sent: 2021年2月2日 14:03 > To: Biwen Li (OSS) <biwen.li@oss.nxp.com> > Cc: Jiafei Pan <jiafei.pan@nxp.com>; u-boot@lists.denx.de; Xiaobo Xie > <xiaobo.xie@nxp.com>; Biwen Li <biwen.li@nxp.com> > Subject: RE: [v3 16/33] configs: ls1021atwr: enable CONFIG_MPC8XXX_GPIO > > >-----Original Message----- > >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Biwen Li > >Sent: Thursday, January 28, 2021 3:10 PM > >To: Priyanka Jain <priyanka.jain@nxp.com> > >Cc: Jiafei Pan <jiafei.pan@nxp.com>; u-boot@lists.denx.de; Xiaobo Xie > ><xiaobo.xie@nxp.com>; Biwen Li <biwen.li@nxp.com> > >Subject: [v3 16/33] configs: ls1021atwr: enable CONFIG_MPC8XXX_GPIO > > > >From: Biwen Li <biwen.li@nxp.com> > > > >Enable CONFIG_MPC8XXX_GPIO for board ls1021atwr > > > >Signed-off-by: Biwen Li <biwen.li@nxp.com> > >--- > <snip> > Kindly fix below build error for ls1021atwr platforms > > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: In function â > mpc8xxx_gpio_get_valâ : > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:50:29: error: > dereferencing pointer to incomplete type â struct ccsr_gpioâ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) return in_le32(&data->base->gpdat) & mask; > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ^ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > +ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../include/linux/byteorder/little_endian.h:35:51: > note: in definition of macro â __le32_to_cpuâ (ls1021atwr_nor > ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi > ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) #define __le32_to_cpu(x) ((__force > __u32)(__le32)(x)) > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) > ^ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > +ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../arch/arm/include/asm/io.h:105:25: note: in > expansion of macro â __arch_getlâ (ls1021atwr_nor ls1021atwr_nor_lpuart > ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define > __raw_readl(a) __arch_getl(a) > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ^~~~~~~~~~~ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > +ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../arch/arm/include/asm/io.h:173:49: note: in > expansion of macro â __raw_readlâ (ls1021atwr_nor ls1021atwr_nor_lpuart > ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define > in_arch(type,endian,a) endian##_to_cpu(__raw_read##type(a)) > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) > ^~~~~~~~~~ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > +ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../arch/arm/include/asm/io.h:180:20: note: in > expansion of macro â in_archâ (ls1021atwr_nor ls1021atwr_nor_lpuart > ls1021atwr_nor_SECURE_BOOT ls1021atwr_qspi ls1021atwr_sdcard_ifc > ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021atwr_sdcard_qspi) #define > in_le32(a) in_arch(l,le32,a) > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ^~~~~~~ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:50:10: note: in > expansion of macro â in_le32â > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ^~~~~~~ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: In function â > mpc8xxx_gpio_of_to_platâ : > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:184:6: error: > dereferencing pointer to incomplete type â struct mpc8xxx_gpio_platâ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) plat->addr = (ulong)dev_read_addr_size_index(dev, > 0, (fdt_size_t *)&plat->size); > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ^~ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: In function â > mpc8xxx_gpio_plat_to_privâ : > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c:195:27: error: > dereferencing pointer to incomplete type â struct mpc8xxx_gpio_platâ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) unsigned long size = plat->size; > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ^~ > +(ls1021atwr_nor ls1021atwr_nor_lpuart ls1021atwr_nor_SECURE_BOOT > ls1021atwr_qspi ls1021atwr_sdcard_ifc ls1021atwr_sdcard_ifc_SECURE_BOOT > ls1021atwr_sdcard_qspi) ../drivers/gpio/mpc8xxx_gpio.c: At top level: Sure, np. Updated in v4. > > Regards > Priyanka
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h index 3e85bb3850..dfb56437d9 100644 --- a/include/configs/ls1021atwr.h +++ b/include/configs/ls1021atwr.h @@ -219,6 +219,13 @@ #define CONFIG_SYS_I2C_MXC_I2C2 /* enable I2C bus 2 */ #define CONFIG_SYS_I2C_MXC_I2C3 /* enable I2C bus 3 */ +/* GPIO */ +#ifdef CONFIG_DM_GPIO +#ifndef CONFIG_MPC8XXX_GPIO +#define CONFIG_MPC8XXX_GPIO +#endif +#endif + /* EEPROM */ #define CONFIG_ID_EEPROM #define CONFIG_SYS_I2C_EEPROM_NXID