| Message ID | 20210127160110.1387428-1-marex@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | spi: imx: Implement set_speed | expand |
On Thu, Jan 28, 2021 at 12:01 AM Marek Vasut <marex@denx.de> wrote: > > The set_speed() callback should configure the bus speed, make it so. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Stefano Babic <sbabic@denx.de> > --- > drivers/spi/mxc_spi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c > index 553a0315df5..47100d89aef 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -661,7 +661,10 @@ static int mxc_spi_release_bus(struct udevice *dev) > > static int mxc_spi_set_speed(struct udevice *bus, uint speed) > { > - /* Nothing to do */ > + struct mxc_spi_slave *mxcs = dev_get_platdata(bus); This is now renamed to dev_get_plat() > + > + mxcs->max_hz = speed; > + > return 0; > } > Otherwise, Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 2/2/21 4:10 AM, Bin Meng wrote: > On Thu, Jan 28, 2021 at 12:01 AM Marek Vasut <marex@denx.de> wrote: >> >> The set_speed() callback should configure the bus speed, make it so. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Stefano Babic <sbabic@denx.de> >> --- >> drivers/spi/mxc_spi.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c >> index 553a0315df5..47100d89aef 100644 >> --- a/drivers/spi/mxc_spi.c >> +++ b/drivers/spi/mxc_spi.c >> @@ -661,7 +661,10 @@ static int mxc_spi_release_bus(struct udevice *dev) >> >> static int mxc_spi_set_speed(struct udevice *bus, uint speed) >> { >> - /* Nothing to do */ >> + struct mxc_spi_slave *mxcs = dev_get_platdata(bus); > > This is now renamed to dev_get_plat() Fixed in V2, thanks.
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index 553a0315df5..47100d89aef 100644 --- a/drivers/spi/mxc_spi.c +++ b/drivers/spi/mxc_spi.c @@ -661,7 +661,10 @@ static int mxc_spi_release_bus(struct udevice *dev) static int mxc_spi_set_speed(struct udevice *bus, uint speed) { - /* Nothing to do */ + struct mxc_spi_slave *mxcs = dev_get_platdata(bus); + + mxcs->max_hz = speed; + return 0; }
The set_speed() callback should configure the bus speed, make it so. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Jagan Teki <jagan@amarulasolutions.com> Cc: Stefano Babic <sbabic@denx.de> --- drivers/spi/mxc_spi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)