diff mbox series

[1/3] test: inconsistent bootm tests

Message ID 20210117231735.34139-1-xypron.glpk@gmx.de
State Accepted
Delegated to: Tom Rini
Headers show
Series [1/3] test: inconsistent bootm tests | expand

Commit Message

Heinrich Schuchardt Jan. 17, 2021, 11:17 p.m. UTC 
Excluding ut bootm in test/cmd_ut.c but compiling test/bootm.c results in
failure of the Python test invoking the C unit tests as observed on
sipeed_riscv_smode_defconfig:

FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_nop]
FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_nospace]
FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_silent]
FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_silent_var]
FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst]
FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst_both]
FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst_var]

Only compile test/bootm.c on the sandbox.

Fixes: f158ba15ee0f ("bootm: Add tests for fixup_silent_linux()")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 test/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.29.2

Comments

Simon Glass Jan. 19, 2021, 6:06 p.m. UTC | #1 
On Sun, 17 Jan 2021 at 16:22, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Excluding ut bootm in test/cmd_ut.c but compiling test/bootm.c results in
> failure of the Python test invoking the C unit tests as observed on
> sipeed_riscv_smode_defconfig:
>
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_nop]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_nospace]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_silent]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_silent_var]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst_both]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst_var]
>
> Only compile test/bootm.c on the sandbox.
>
> Fixes: f158ba15ee0f ("bootm: Add tests for fixup_silent_linux()")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  test/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 30, 2021, 7:20 p.m. UTC | #2 
On Mon, Jan 18, 2021 at 12:17:33AM +0100, Heinrich Schuchardt wrote:

> Excluding ut bootm in test/cmd_ut.c but compiling test/bootm.c results in
> failure of the Python test invoking the C unit tests as observed on
> sipeed_riscv_smode_defconfig:
> 
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_nop]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_nospace]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_silent]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_silent_var]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst_both]
> FAILED test/py/tests/test_ut.py::test_ut[ut_bootm_subst_var]
> 
> Only compile test/bootm.c on the sandbox.
> 
> Fixes: f158ba15ee0f ("bootm: Add tests for fixup_silent_linux()")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/test/Makefile b/test/Makefile
index d4323f9963..7d3fc29493 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -4,8 +4,8 @@ 

 ifneq ($(CONFIG_SANDBOX),)
 obj-$(CONFIG_$(SPL_)CMDLINE) += bloblist.o
-endif
 obj-$(CONFIG_$(SPL_)CMDLINE) += bootm.o
+endif
 obj-$(CONFIG_$(SPL_)CMDLINE) += cmd/
 obj-$(CONFIG_$(SPL_)CMDLINE) += cmd_ut.o
 obj-$(CONFIG_$(SPL_)CMDLINE) += command_ut.o