From patchwork Sat Jan 16 21:51:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1427590 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=j4JKL0Vr; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DJBby16VQz9sVr for ; Sun, 17 Jan 2021 08:52:30 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B5A3C82999; Sat, 16 Jan 2021 22:52:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="j4JKL0Vr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6996B8299E; Sat, 16 Jan 2021 22:51:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 441AF82992 for ; Sat, 16 Jan 2021 22:51:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-io1-xd34.google.com with SMTP id q2so23730555iow.13 for ; Sat, 16 Jan 2021 13:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EL720qXpnGvokxX7uXRgbf5vSQoSgrKfwUi+wLjPH78=; b=j4JKL0VrRKaHXhFXb+xACQIzI19vhejwW5oKJnu4AiWalRSzHvSPd/EsU7Go+VN1gw vuCoS5a2JBpcAV3jfmUAZ89X4Iq1GJM69tJ+1g4fuuAnLr3SweU6RMVXshrOPbB5ynJ/ guYkvnxQygXubqUGAZESc3oQJv6mVgpaXIUBQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EL720qXpnGvokxX7uXRgbf5vSQoSgrKfwUi+wLjPH78=; b=ro9zj7oxMavDZpDpSACnqCpYpv68jNBjsnQ7F3b40+0CfHAmc4A//nez1rY8i0vvKk rFmwy8bAsO/U4cEpTcNMT8Xvhm1ZmdkeTtrVuE9XYHCc+g4vclykqgwbAiSF404f7F82 3xU4fXR+EwGIBZv68WOKRX8m2AIX6mCsOAjuU1plVNaOcbC1mNYad0UYJTyhDkHQO8Q4 SXgwD7PqOMSX41/kjXKyFkNpi6zAQSDgeC2d3YbVYiB0Ko65iaM2r/ePvT5DeBa8nq42 C6E0Jdb3lJPGpJ+ndTuXsjV/lgz7czrzMgLybBJSqCirnQlprUPBgYzcx6Lp+9jfIW6J tSQQ== X-Gm-Message-State: AOAM5335ILRAflRWmBlgafwQf6MVhhB1arUaSD7rK3jqj1XUaCb8G4GS 1lwvFvk6qHmU1zm3t8tvdiOyUz1WVH58q3TO X-Google-Smtp-Source: ABdhPJzF8NZKHLGmBy8xnQFQzi7BJ/UPzyOEMsh87w9m23GW5hb461uPG0usc9OarSolnNd9ZuoM5A== X-Received: by 2002:a02:b78e:: with SMTP id f14mr7531542jam.97.1610833907699; Sat, 16 Jan 2021 13:51:47 -0800 (PST) Received: from localhost.localdomain (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id r19sm7519665ila.70.2021.01.16.13.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jan 2021 13:51:47 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Simon Glass Subject: [PATCH 03/11] tpm: Add debugging of request in tpm_sendrecv_command() Date: Sat, 16 Jan 2021 14:51:30 -0700 Message-Id: <20210116215138.1218256-4-sjg@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog In-Reply-To: <20210116215138.1218256-1-sjg@chromium.org> References: <20210116215138.1218256-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The response is shown but not the request. Update the code to show both if debugging is enabled. Signed-off-by: Simon Glass --- lib/tpm-common.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/tpm-common.c b/lib/tpm-common.c index e4af87f76aa..0255d3bd9cf 100644 --- a/lib/tpm-common.c +++ b/lib/tpm-common.c @@ -165,7 +165,7 @@ u32 tpm_sendrecv_command(struct udevice *dev, const void *command, int err, ret; u8 response_buffer[COMMAND_BUFFER_SIZE]; size_t response_length; - int i; + int i, size; if (response) { response_length = *size_ptr; @@ -174,8 +174,13 @@ u32 tpm_sendrecv_command(struct udevice *dev, const void *command, response_length = sizeof(response_buffer); } - err = tpm_xfer(dev, command, tpm_command_size(command), - response, &response_length); + size = tpm_command_size(command); + log_debug("TPM request [size:%d]: ", size); + for (i = 0; i < size; i++) + log_debug("%02x ", ((u8 *)command)[i]); + log_debug("\n"); + + err = tpm_xfer(dev, command, size, response, &response_length); if (err < 0) return err;