Message ID | 20210116145343.9.I4b95684e6aab3bd37291a7c679f621e9f8676a4c@changeid |
---|---|
State | Superseded |
Delegated to: | Bin Meng |
Headers | show |
Series | x86: Minor improvements mostly for image loading | expand |
On Sun, Jan 17, 2021 at 5:54 AM Simon Glass <sjg@chromium.org> wrote: > > This should be done even if not using TPL, since BSS may be in use or > boards that only use SPL. Fix it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/lib/spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/arch/x86/lib/spl.c b/arch/x86/lib/spl.c index cf22fa2d7b5..6699de49c63 100644 --- a/arch/x86/lib/spl.c +++ b/arch/x86/lib/spl.c @@ -115,8 +115,8 @@ static int x86_spl_init(void) } #ifndef CONFIG_SYS_COREBOOT -# ifndef CONFIG_TPL memset(&__bss_start, 0, (ulong)&__bss_end - (ulong)&__bss_start); +# ifndef CONFIG_TPL /* TODO(sjg@chromium.org): Consider calling cpu_init_r() here */ ret = interrupt_init();
This should be done even if not using TPL, since BSS may be in use or boards that only use SPL. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/lib/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)