diff mbox series

[1/3] efi_loader: fixup protocol, avoid forward declaration

Message ID 20210116085223.33867-2-xypron.glpk@gmx.de
State Accepted, archived
Commit 535c473e10b32036ea0f2900bc6986f30e76c696
Delegated to: Heinrich Schuchardt
Headers show
Series efi_loader: make protocols configurable | expand

Commit Message

Heinrich Schuchardt Jan. 16, 2021, 8:52 a.m. UTC 
Avoid a forward declaration.

Add a missing function description.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/efi_loader/efi_dt_fixup.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

--
2.29.2
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_dt_fixup.c b/lib/efi_loader/efi_dt_fixup.c
index 5f0ae5c338..c2f2daef33 100644
--- a/lib/efi_loader/efi_dt_fixup.c
+++ b/lib/efi_loader/efi_dt_fixup.c
@@ -10,16 +10,6 @@ 
 #include <efi_loader.h>
 #include <mapmem.h>

-static efi_status_t EFIAPI efi_dt_fixup(struct efi_dt_fixup_protocol *this,
-					void *dtb,
-					efi_uintn_t *buffer_size,
-					u32 flags);
-
-struct efi_dt_fixup_protocol efi_dt_fixup_prot = {
-	.revision = EFI_DT_FIXUP_PROTOCOL_REVISION,
-	.fixup = efi_dt_fixup
-};
-
 const efi_guid_t efi_guid_dt_fixup_protocol = EFI_DT_FIXUP_PROTOCOL_GUID;

 /**
@@ -102,6 +92,18 @@  void efi_carve_out_dt_rsv(void *fdt)
 	}
 }

+/**
+ * efi_dt_fixup() - fix up device tree
+ *
+ * This function implements the Fixup() service of the
+ * EFI Device Tree Fixup Protocol.
+ *
+ * @this:		instance of the protocol
+ * @dtb:		device tree provided by caller
+ * @buffer_size:	size of buffer for the device tree including free space
+ * @flags:		bit field designating action to be performed
+ * Return:		status code
+ */
 static efi_status_t EFIAPI efi_dt_fixup(struct efi_dt_fixup_protocol *this,
 					void *dtb,
 					efi_uintn_t *buffer_size,
@@ -158,3 +160,8 @@  static efi_status_t EFIAPI efi_dt_fixup(struct efi_dt_fixup_protocol *this,
 out:
 	return EFI_EXIT(ret);
 }
+
+struct efi_dt_fixup_protocol efi_dt_fixup_prot = {
+	.revision = EFI_DT_FIXUP_PROTOCOL_REVISION,
+	.fixup = efi_dt_fixup
+};