diff mbox series

[RFC,v4,4/8] dm: pci: Correct use of wrong flag name

Message ID 20210108051636.2928002-5-sjg@chromium.org
State RFC
Delegated to: Simon Glass
Headers show
Series RFC: dm: core: Add support for vital devices | expand

Commit Message

Simon Glass Jan. 8, 2021, 5:16 a.m. UTC 
Update a driver that uses the incorrect flag. Add a comment to hopefully
prevent furture mistakes.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 drivers/pci/pcie_iproc.c | 2 +-
 include/dm/device.h      | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/pci/pcie_iproc.c b/drivers/pci/pcie_iproc.c
index 6725ff64372..12ce9d525ca 100644
--- a/drivers/pci/pcie_iproc.c
+++ b/drivers/pci/pcie_iproc.c
@@ -1283,5 +1283,5 @@  U_BOOT_DRIVER(pci_iproc) = {
 	.probe = iproc_pcie_probe,
 	.remove = iproc_pcie_remove,
 	.priv_auto	= sizeof(struct iproc_pcie),
-	.flags = DM_REMOVE_OS_PREPARE,
+	.flags = DM_FLAG_OS_PREPARE,
 };
diff --git a/include/dm/device.h b/include/dm/device.h
index a52bbdc3a63..2554f679277 100644
--- a/include/dm/device.h
+++ b/include/dm/device.h
@@ -77,6 +77,9 @@  struct driver_info;
  * One or multiple of these flags are passed to device_remove() so that
  * a selective device removal as specified by the remove-stage and the
  * driver flags can be done.
+ *
+ * DO NOT use these flags in your driver's @flags value...
+ *	use the above DM_FLAG_... values instead
  */
 enum {
 	/* Normal remove, remove all devices */