diff mbox series

Include support for dev_xxx macros

Message ID 20210106153052.2630-1-Gireesh.Hiremath@in.bosch.com
State Changes Requested
Delegated to: Lokesh Vutla
Headers show
Series Include support for dev_xxx macros | expand

Commit Message

Gireesh Hiremath Jan. 6, 2021, 3:30 p.m. UTC
From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

Now that linux/compat.h does not define dev_xxx macros, we need
to include dm/device_compat.h to use dev_xxx macros

Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>
---
 drivers/video/am335x-fb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Lokesh Vutla Jan. 17, 2021, 10:43 a.m. UTC | #1
Hi,

On 06/01/21 9:00 pm, Gireesh.Hiremath@in.bosch.com wrote:
> From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>
> 
> Now that linux/compat.h does not define dev_xxx macros, we need
> to include dm/device_compat.h to use dev_xxx macros
> 
> Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

I did not get the complete intention of this patch. Are there any build warnings
that are fixed with including the relevant #include. If not this patch should be
squashed with the patch that introduces the usage of dev_xxx macros.

Thanks and regards,
Lokesh

> ---
>  drivers/video/am335x-fb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
> index f4ccdc3b05..e802b3bb83 100644
> --- a/drivers/video/am335x-fb.c
> +++ b/drivers/video/am335x-fb.c
> @@ -13,6 +13,7 @@
>   */
>  #include <common.h>
>  #include <dm.h>
> +#include <dm/device_compat.h>
>  #include <lcd.h>
>  #include <log.h>
>  #include <video.h>
>
diff mbox series

Patch

diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
index f4ccdc3b05..e802b3bb83 100644
--- a/drivers/video/am335x-fb.c
+++ b/drivers/video/am335x-fb.c
@@ -13,6 +13,7 @@ 
  */
 #include <common.h>
 #include <dm.h>
+#include <dm/device_compat.h>
 #include <lcd.h>
 #include <log.h>
 #include <video.h>