| Message ID | 20201216231624.9724-3-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v2,1/7] console: Introduce console_start() and console_stop() | expand |
On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > search_device() is defined in console.c. Move its declaration > to an appropriate header file. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: new patch > include/console.h | 2 ++ > include/iomux.h | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> > > diff --git a/include/console.h b/include/console.h > index 233ff323e1ee..79f9534a9535 100644 > --- a/include/console.h > +++ b/include/console.h > @@ -25,6 +25,8 @@ void clear_ctrlc(void); /* clear the Control-C condition */ > int disable_ctrlc(int); /* 1 to disable, 0 to enable Control-C detect */ > int confirm_yesno(void); /* 1 if input is "y", "Y", "yes" or "YES" */ > > +struct stdio_dev *search_device(int flags, const char *name); > + > #ifdef CONFIG_CONSOLE_RECORD > /** > * console_record_init() - set up the console recording buffers > diff --git a/include/iomux.h b/include/iomux.h > index e6e1097db5b2..da7ff697d218 100644 > --- a/include/iomux.h > +++ b/include/iomux.h > @@ -26,6 +26,5 @@ extern int cd_count[MAX_FILES]; > > int iomux_doenv(const int, const char *); > void iomux_printdevs(const int); > -struct stdio_dev *search_device(int, const char *); Please add a full function comment Also consider renaming it to console_search_dev() or similar, since it is in console.h > > #endif /* _IO_MUX_H */ > -- > 2.29.2 > Regards, Simon
diff --git a/include/console.h b/include/console.h index 233ff323e1ee..79f9534a9535 100644 --- a/include/console.h +++ b/include/console.h @@ -25,6 +25,8 @@ void clear_ctrlc(void); /* clear the Control-C condition */ int disable_ctrlc(int); /* 1 to disable, 0 to enable Control-C detect */ int confirm_yesno(void); /* 1 if input is "y", "Y", "yes" or "YES" */ +struct stdio_dev *search_device(int flags, const char *name); + #ifdef CONFIG_CONSOLE_RECORD /** * console_record_init() - set up the console recording buffers diff --git a/include/iomux.h b/include/iomux.h index e6e1097db5b2..da7ff697d218 100644 --- a/include/iomux.h +++ b/include/iomux.h @@ -26,6 +26,5 @@ extern int cd_count[MAX_FILES]; int iomux_doenv(const int, const char *); void iomux_printdevs(const int); -struct stdio_dev *search_device(int, const char *); #endif /* _IO_MUX_H */
search_device() is defined in console.c. Move its declaration to an appropriate header file. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: new patch include/console.h | 2 ++ include/iomux.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-)