[08/27] dm: Fix return value in dev_read_alias_seq()

Message ID	20201130015402.2328621-7-sjg@chromium.org
State	Superseded
Delegated to:	Simon Glass
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Simon Glass <sjg@chromium.org>, Marek Vasut <marex@denx.de>, Pavel Herrmann <morpheus.ibis@gmail.com> Subject: [PATCH 08/27] dm: Fix return value in dev_read_alias_seq() Date: Sun, 29 Nov 2020 18:53:43 -0700 Message-Id: <20201130015402.2328621-7-sjg@chromium.org> In-Reply-To: <20201130015402.2328621-1-sjg@chromium.org> References: <20201130015402.2328621-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	dm: Change the way sequence numbers are implemented \| expand [00/27] dm: Change the way sequence numbers are implemented [01/27] linker_lists: Fix alignment issue [02/27] efi: Drop unwanted message in efi_uc_destroy() [03/27] dm: Avoid accessing seq directly [04/27] dm: core: Update uclass_find_next_free_req_seq() args [05/27] dm: core: Add a new sequence number for devices [06/27] dm: test: Add support for new sequence numbers [07/27] dm: core: Switch binding to use new sequence numbers [08/27] dm: Fix return value in dev_read_alias_seq() [09/27] dm: test: Drop assumptions of no sequence numbers [10/27] octeon: Don't attempt to set the sequence number [11/27] i2c: Update for new sequence numbers [12/27] net: Update to use new sequence numbers [13/27] pci: Update to use new sequence numbers [14/27] spi: Update for new sequence numbers [15/27] usb: ehci-mx6: Drop assignment of sequence number [16/27] usb: Update for new sequence numbers [17/27] x86: Drop unnecessary mp_init logic [18/27] x86: Simplify acpi_device_infer_name() [19/27] gpio: Update for new sequence numbers [20/27] pinctrl: Update for new sequence numbers [21/27] dm: Switch over to use new sequence number for dev_seq() [22/27] dm: Drop uclass_resolve_seq() [23/27] dm: Drop the unused arg in uclass_find_device_by_seq() [24/27] dm: core: Simplify uclass_find_next_free_req_seq() [25/27] cmd: Drop use of old sequence numbers in commands [26/27] dm: core: Drop seq and req_seq [27/27] dm: Update documentation for new sequence numbers

Message ID

20201130015402.2328621-7-sjg@chromium.org

State

Superseded

Delegated to:

Simon Glass

Headers

From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Simon Glass <sjg@chromium.org>, Marek Vasut <marex@denx.de>,
 Pavel Herrmann <morpheus.ibis@gmail.com>
Subject: [PATCH 08/27] dm: Fix return value in dev_read_alias_seq()
Date: Sun, 29 Nov 2020 18:53:43 -0700
Message-Id: <20201130015402.2328621-7-sjg@chromium.org>
In-Reply-To: <20201130015402.2328621-1-sjg@chromium.org>
References: <20201130015402.2328621-1-sjg@chromium.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

dm: Change the way sequence numbers are implemented | expand

Commit Message

Simon Glass Nov. 30, 2020, 1:53 a.m. UTC

This should return 0 on success but currently does not. Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/core/read.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/core/read.c b/drivers/core/read.c
index 076125824ca..fc74d64814f 100644
--- a/drivers/core/read.c
+++ b/drivers/core/read.c
@@ -281,8 +281,10 @@  int dev_read_alias_seq(const struct udevice *dev, int *devnump)
 
 	if (ofnode_is_np(node)) {
 		ret = of_alias_get_id(ofnode_to_np(node), uc_name);
-		if (ret >= 0)
+		if (ret >= 0) {
 			*devnump = ret;
+			ret = 0;
+		}
 	} else {
 #if CONFIG_IS_ENABLED(OF_CONTROL)
 		ret = fdtdec_get_alias_seq(gd->fdt_blob, uc_name,

[08/27] dm: Fix return value in dev_read_alias_seq()

Commit Message

Patch