diff mbox series

watchdog: sbsa: timeout should be in "millisecond"

Message ID 20201125045547.30800-1-qiang.zhao@nxp.com
State Accepted
Commit c2ba01c082b4ab21e43bb15e1c3a7e19573d1133
Delegated to: Tom Rini
Headers show
Series watchdog: sbsa: timeout should be in "millisecond" | expand

Commit Message

Qiang Zhao Nov. 25, 2020, 4:55 a.m. UTC 
From: Zhao Qiang <qiang.zhao@nxp.com>

timeout should be in "millisecond" instead of second,
so divided it by 1000 when calculate the load value.

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
 drivers/watchdog/sbsa_gwdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Dec. 3, 2020, 4:59 p.m. UTC | #1 
On Wed, Nov 25, 2020 at 12:55:47PM +0800, Qiang Zhao wrote:

> From: Zhao Qiang <qiang.zhao@nxp.com>
> 
> timeout should be in "millisecond" instead of second,
> so divided it by 1000 when calculate the load value.
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
index 2eae431..96285c1 100644
--- a/drivers/watchdog/sbsa_gwdt.c
+++ b/drivers/watchdog/sbsa_gwdt.c
@@ -61,7 +61,7 @@  static int sbsa_gwdt_start(struct udevice *dev, u64 timeout, ulong flags)
 	 * to half value of timeout.
 	 */
 	clk = get_tbclk();
-	writel(clk / 2 * timeout,
+	writel(clk / (2 * 1000) * timeout,
 	       priv->reg_control + SBSA_GWDT_WOR);
 
 	/* writing WCS will cause an explicit watchdog refresh */