diff mbox series

[2/3] x86: zimage: Update cmdline parameter to be an env var

Message ID 20201109071220.2.I527e57c5ebe2b808b311693765b53a8219ef458d@changeid
State Accepted
Commit 6c9a83502facf265406bc87f7a6949cc3c66872d
Delegated to: Bin Meng
Headers show
Series [1/3] x86: coral: Update smbios tables to latest definition | expand

Commit Message

Simon Glass Nov. 9, 2020, 2:12 p.m. UTC
With the updated changes to bootargs substitution[1], the zboot command
needs to be updated to get its command line from an environment variable
instead of a memory address. This is because the command-line string must
be updated to convert %U to ${uuid}, etc.

In any case it is more flexible to use a environment variable and it is
best to do this before the release to avoid a subsequent change.

Update the command accordingly.

[1] http://patchwork.ozlabs.org/project/uboot/list/?series=212481

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 arch/x86/lib/zimage.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

Comments

Bin Meng Dec. 16, 2020, 3:26 a.m. UTC | #1
On Mon, Nov 9, 2020 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
>
> With the updated changes to bootargs substitution[1], the zboot command
> needs to be updated to get its command line from an environment variable
> instead of a memory address. This is because the command-line string must
> be updated to convert %U to ${uuid}, etc.
>
> In any case it is more flexible to use a environment variable and it is
> best to do this before the release to avoid a subsequent change.
>
> Update the command accordingly.
>
> [1] http://patchwork.ozlabs.org/project/uboot/list/?series=212481
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  arch/x86/lib/zimage.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Dec. 16, 2020, 5:52 a.m. UTC | #2
On Wed, Dec 16, 2020 at 11:26 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Nov 9, 2020 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > With the updated changes to bootargs substitution[1], the zboot command
> > needs to be updated to get its command line from an environment variable
> > instead of a memory address. This is because the command-line string must
> > be updated to convert %U to ${uuid}, etc.
> >
> > In any case it is more flexible to use a environment variable and it is
> > best to do this before the release to avoid a subsequent change.
> >
> > Update the command accordingly.
> >
> > [1] http://patchwork.ozlabs.org/project/uboot/list/?series=212481
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  arch/x86/lib/zimage.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c
index f154827ec70..708025b2071 100644
--- a/arch/x86/lib/zimage.c
+++ b/arch/x86/lib/zimage.c
@@ -61,8 +61,8 @@ 
  *	BZIMAGE_LOAD_ADDR or ZIMAGE_LOAD_ADDR
  * @base_ptr: Pointer to the boot parameters, typically at address
  *	DEFAULT_SETUP_BASE
- * @cmdline: Address of 'override' command line, or 0 to use the one in the
- *	setup block
+ * @cmdline: Environment variable containing the 'override' command line, or
+ *	NULL to use the one in the setup block
  */
 struct zboot_state {
 	ulong bzimage_addr;
@@ -71,7 +71,7 @@  struct zboot_state {
 	ulong initrd_size;
 	ulong load_address;
 	struct boot_params *base_ptr;
-	ulong cmdline;
+	char *cmdline;
 } state;
 
 enum {
@@ -420,7 +420,7 @@  static int do_zboot_start(struct cmd_tbl *cmdtp, int flag, int argc,
 		state.bzimage_addr = 0;
 	}
 	if (argc >= 7)
-		state.cmdline = simple_strtoul(argv[6], NULL, 16);
+		state.cmdline = env_get(argv[6]);
 
 	return 0;
 }
@@ -466,7 +466,7 @@  static int do_zboot_setup(struct cmd_tbl *cmdtp, int flag, int argc,
 	}
 	ret = setup_zimage(base_ptr, (char *)base_ptr + COMMAND_LINE_OFFSET,
 			   0, state.initrd_addr, state.initrd_size,
-			   state.cmdline);
+			   (ulong)state.cmdline);
 	if (ret) {
 		puts("Setting up boot parameters failed ...\n");
 		return CMD_RET_FAILURE;
@@ -757,8 +757,9 @@  U_BOOT_CMDREP_COMPLETE(
 	"      initrd size - The size of the initrd image to use, if any.\n"
 	"      setup -       The address of the kernel setup region, if this\n"
 	"                    is not at addr\n"
-	"      cmdline -     The address of the kernel command line, to\n"
-	"                    override U-Boot's normal cmdline generation\n"
+	"      cmdline -     Environment variable containing the kernel\n"
+	"                    command line, to override U-Boot's normal\n"
+	"                    cmdline generation\n"
 	"\n"
 	"Sub-commands to do part of the zboot sequence:\n"
 	"\tstart [addr [arg ...]] - specify arguments\n"