diff mbox series

[1/3] x86: coral: Update smbios tables to latest definition

Message ID 20201109071220.1.I7953ac0c0e042eb6e108f600ab08d1cb04258604@changeid
State Accepted
Commit ca010674edb289b1f623e83b4529b6d9ae5e5c0d
Delegated to: Bin Meng
Headers show
Series [1/3] x86: coral: Update smbios tables to latest definition | expand

Commit Message

Simon Glass Nov. 9, 2020, 2:12 p.m. UTC
The accepted binding uses multiple nodes, one for each table type. Update
coral accordingly.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 arch/x86/dts/chromebook_coral.dts | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

Comments

Bin Meng Nov. 10, 2020, 1:43 a.m. UTC | #1
On Mon, Nov 9, 2020 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
>
> The accepted binding uses multiple nodes, one for each table type. Update
> coral accordingly.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  arch/x86/dts/chromebook_coral.dts | 27 +++++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Nov. 10, 2020, 1:45 a.m. UTC | #2
On Tue, Nov 10, 2020 at 9:43 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Nov 9, 2020 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > The accepted binding uses multiple nodes, one for each table type. Update
> > coral accordingly.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  arch/x86/dts/chromebook_coral.dts | 27 +++++++++++++++++++++------
> >  1 file changed, 21 insertions(+), 6 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/dts/chromebook_coral.dts b/arch/x86/dts/chromebook_coral.dts
index 43f4b33da1b..d66e128ae62 100644
--- a/arch/x86/dts/chromebook_coral.dts
+++ b/arch/x86/dts/chromebook_coral.dts
@@ -55,12 +55,27 @@ 
 		write-protect-gpios = <&gpio_nw GPIO_75 GPIO_ACTIVE_HIGH>;
 		phase-enforce-gpios = <&gpio_n GPIO_10 GPIO_ACTIVE_HIGH>;
 		smbios {
-			manufacturer = "Google";
-			product = "Coral";
-			version = "rev2";
-			serial = "123456789";
-			sku = "sku3";
-			family = "Google_Coral";
+			/* Type 1 table */
+			system {
+				manufacturer = "Google";
+				product = "Coral";
+				version = "rev2";
+				serial = "123456789";
+				sku = "sku3";
+				family = "Google_Coral";
+			};
+
+			/* Type 2 table */
+			baseboard {
+				manufacturer = "Google";
+				product = "Coral";
+				asset-tag = "ABC123";
+			};
+
+			/* Type 3 table */
+			chassis {
+				manufacturer = "Google";
+			};
 		};
 	};