diff mbox series

[v2,13/28] fs/squashfs: sqfs_read: fix dangling pointer dirs->entry

Message ID 20201103111126.23600-14-richard.genoud@posteo.net
State Accepted
Commit d1d8d75f69f82f7ef7c55b58a7d9e73055956f3c
Delegated to: Tom Rini
Headers show
Series fs/squashfs: fix memory leaks and introduce exists() function | expand

Commit Message

Richard Genoud Nov. 3, 2020, 11:11 a.m. UTC 
dirs->entry shouldn't be left dangling as it could be freed twice.

Signed-off-by: Richard Genoud <richard.genoud@posteo.net>
---
 fs/squashfs/sqfs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini Nov. 20, 2020, 1:37 a.m. UTC | #1 
On Tue, Nov 03, 2020 at 12:11:11PM +0100, Richard Genoud wrote:

> dirs->entry shouldn't be left dangling as it could be freed twice.
> 
> Signed-off-by: Richard Genoud <richard.genoud@posteo.net>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
index f4cac3e4bf0..13e64bea934 100644
--- a/fs/squashfs/sqfs.c
+++ b/fs/squashfs/sqfs.c
@@ -1336,6 +1336,7 @@  int sqfs_read(const char *filename, void *buf, loff_t offset, loff_t len,
 			break;
 
 		free(dirs->entry);
+		dirs->entry = NULL;
 	}
 
 	if (ret) {