diff mbox series

[3/4] IPQ40xx: clk: dont always return 0

Message ID 20201028125626.40067-3-robert.marko@sartura.hr
State New
Delegated to: Tom Rini
Headers show
Series [1/4] IPQ40xx: clk: use dev_read_addr() | expand

Commit Message

Robert Marko Oct. 28, 2020, 12:56 p.m. UTC
Currently the driver will go through the clock ID-s and set/enable them as needed.
But if the ID is unknown it will fall through the switch case to the default case which will always return 0.

This is not correct and default cases should return a error code since clock ID is unknown.
So lets return -EINVAL instead.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/mach-ipq40xx/clock-ipq4019.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c b/arch/arm/mach-ipq40xx/clock-ipq4019.c
index ac2b830353..7308563ad1 100644
--- a/arch/arm/mach-ipq40xx/clock-ipq4019.c
+++ b/arch/arm/mach-ipq40xx/clock-ipq4019.c
@@ -26,7 +26,7 @@  ulong msm_set_rate(struct clk *clk, ulong rate)
 		/* This clock is already initialized by SBL1 */
 		return 0;
 	default:
-		return 0;
+		return -EINVAL;
 	}
 }
 
@@ -56,7 +56,7 @@  static int msm_enable(struct clk *clk)
 		/* This clock is already initialized by SBL1 */
 		return 0;
 	default:
-		return 0;
+		return -EINVAL;
 	}
 }