diff mbox series

[1/4] IPQ40xx: clk: use dev_read_addr()

Message ID 20201028125626.40067-1-robert.marko@sartura.hr
State New
Delegated to: Tom Rini
Headers show
Series [1/4] IPQ40xx: clk: use dev_read_addr() | expand

Commit Message

Robert Marko Oct. 28, 2020, 12:56 p.m. UTC
Lets convert the driver to use dev_read_addr() instead of the devfdt_get_addr().

While we are here, lets also alphabetise the includes.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/mach-ipq40xx/clock-ipq4019.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Robert Marko Nov. 19, 2020, 8:16 p.m. UTC | #1
On Wed, Oct 28, 2020 at 1:56 PM Robert Marko <robert.marko@sartura.hr> wrote:
>
> Lets convert the driver to use dev_read_addr() instead of the devfdt_get_addr().
>
> While we are here, lets also alphabetise the includes.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
>  arch/arm/mach-ipq40xx/clock-ipq4019.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c b/arch/arm/mach-ipq40xx/clock-ipq4019.c
> index 31ae9719e8..1f385665cc 100644
> --- a/arch/arm/mach-ipq40xx/clock-ipq4019.c
> +++ b/arch/arm/mach-ipq40xx/clock-ipq4019.c
> @@ -8,8 +8,8 @@
>   *
>   */
>
> -#include <common.h>
>  #include <clk-uclass.h>
> +#include <common.h>
>  #include <dm.h>
>  #include <errno.h>
>
> @@ -35,7 +35,7 @@ static int msm_clk_probe(struct udevice *dev)
>  {
>         struct msm_clk_priv *priv = dev_get_priv(dev);
>
> -       priv->base = devfdt_get_addr(dev);
> +       priv->base = dev_read_addr(dev);
>         if (priv->base == FDT_ADDR_T_NONE)
>                 return -EINVAL;
>
> --
> 2.28.0
>

Hi,
Is there something I can improve in the patch series?

Regards,
Robert
diff mbox series

Patch

diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c b/arch/arm/mach-ipq40xx/clock-ipq4019.c
index 31ae9719e8..1f385665cc 100644
--- a/arch/arm/mach-ipq40xx/clock-ipq4019.c
+++ b/arch/arm/mach-ipq40xx/clock-ipq4019.c
@@ -8,8 +8,8 @@ 
  *
  */
 
-#include <common.h>
 #include <clk-uclass.h>
+#include <common.h>
 #include <dm.h>
 #include <errno.h>
 
@@ -35,7 +35,7 @@  static int msm_clk_probe(struct udevice *dev)
 {
 	struct msm_clk_priv *priv = dev_get_priv(dev);
 
-	priv->base = devfdt_get_addr(dev);
+	priv->base = dev_read_addr(dev);
 	if (priv->base == FDT_ADDR_T_NONE)
 		return -EINVAL;