From patchwork Mon Oct 26 23:40:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1388200 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=ZuGWLYbe; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CKrvh0nnpz9sRK for ; Tue, 27 Oct 2020 10:41:36 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B0E018247D; Tue, 27 Oct 2020 00:40:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZuGWLYbe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CD1B18249E; Tue, 27 Oct 2020 00:40:42 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,T_SPF_HELO_TEMPERROR, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7DBCF823E3 for ; Tue, 27 Oct 2020 00:40:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x132.google.com with SMTP id c11so7879106iln.9 for ; Mon, 26 Oct 2020 16:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0z1vhvG/Rc/lM382/KY0jSnJ13SM+J6R1/tXN/09Xy4=; b=ZuGWLYbepscp2ySyE1tOwLuWxW6d17uy1cLEuUeg1/t0jtnmg2cbakCzbSUi/ritbg wzIQGGxWKi/6srsePHduq9OwByebonrFPw5q7XYz+aDvRDa+SBwNMwu6QOnF+XQjmho6 EX9NNrbXbb9RgHlfaFudEG6vkkM7xv6JsQJvk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0z1vhvG/Rc/lM382/KY0jSnJ13SM+J6R1/tXN/09Xy4=; b=gPWBzpV1V2FxGYPkZyh9+xl2r2U6hkFxgQut5Dbm5cUVDAG4J0FgxJBkrgbiADx9YL hKulOjU/Dn8iiyvyz2aeL+XwJNghdUm9VGGAoFMW3oN6mwp9D3v7E0ycdwKAhkntN+O1 mhKWZhMbJJFi56Iq0k4xD3X2kcdJE7s4TzuUS8aIqMYbK5Xrm/iMIaOW5/NeLpIOd0aJ RdkpVJqdZ21D48VZGbZQWF++0/6eSPDhTQrMb2i34PI99pmkn/ZF3WqK1dRwKj3iEV/8 HKlw03sqBrOxy00J1swtQeIgkD8n5ZaCT3cnIIjGEhvZePcIVVyAyMMQxXRgeMtF2VKE ig5g== X-Gm-Message-State: AOAM530L3IVnXkB2ZxtRdZsvHShW7lACkb3BfgKgH3V8ff5DedmyNXyd UKSkrZem/eCPXqeWiW+NtY/jRNNRagRNSA5I X-Google-Smtp-Source: ABdhPJw63BQsY55O9hx8qCqjAHaNrPvTNAYF0VrUSEHg6uxPRxalwxnJQyAl7ixJ5U+3yko49G6gSw== X-Received: by 2002:a92:1e02:: with SMTP id e2mr13407688ile.294.1603755633181; Mon, 26 Oct 2020 16:40:33 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id e17sm7066857ile.60.2020.10.26.16.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:40:32 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Alper Nebi Yasak , Simon Glass Subject: [PATCH v2 04/28] binman: Give a sensible error if no command is given Date: Mon, 26 Oct 2020 17:40:02 -0600 Message-Id: <20201026234026.1903778-5-sjg@chromium.org> X-Mailer: git-send-email 2.29.0.rc2.309.g374f81d7ae-goog In-Reply-To: <20201026234026.1903778-1-sjg@chromium.org> References: <20201026234026.1903778-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean At present if 'binman' is typed on the command line, a strange error about a missing argument is displayed. Fix this. These does not seem to be standard way to add the 'required' argument in all recent Python versions, so set it manually. Signed-off-by: Simon Glass Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/cmdline.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/binman/cmdline.py b/tools/binman/cmdline.py index bb4d9d1288b..c007d0a036d 100644 --- a/tools/binman/cmdline.py +++ b/tools/binman/cmdline.py @@ -37,6 +37,7 @@ controlled by a description in the board device tree.''' '3=info, 4=detail, 5=debug') subparsers = parser.add_subparsers(dest='cmd') + subparsers.required = True build_parser = subparsers.add_parser('build', help='Build firmware image') build_parser.add_argument('-a', '--entry-arg', type=str, action='append',