From patchwork Mon Oct 26 01:04:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1387382 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=nhmAZvz2; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CKGvS61PJz9sTD for ; Mon, 26 Oct 2020 12:09:24 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5E248253C; Mon, 26 Oct 2020 02:06:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="nhmAZvz2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 28624824C3; Mon, 26 Oct 2020 02:05:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A23482495 for ; Mon, 26 Oct 2020 02:05:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x129.google.com with SMTP id n5so6738411ile.7 for ; Sun, 25 Oct 2020 18:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HcotzKgMdeuMoWAVkHV+hTrul0r8ZEH/D+j3bQgsG7s=; b=nhmAZvz2dwznFsdx2hqpYmS0MKCFHDGqqZUrwFX2jfr0tl3hf8oemuqR/wmfe/yxhR iUjzPP05rbEMCHOCXU/v2/M++kVfWy6GKjkKsSGwEdGGpGnP5I8agJh5Ie9Jbo5EEb1a qcjuNY4lAXgCZkaYDYbqEXdyasNsmLB5W5YaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HcotzKgMdeuMoWAVkHV+hTrul0r8ZEH/D+j3bQgsG7s=; b=hEDdkYIdK4h1hA6sltTUXh4zpMEQRRamnSw0Bom2LQyyocA+dBHKgWfVybNZEeW0iu mnxKNL8U8b0j9MY97STmeyE6YnPUh/ObZcAJMDlcCtPJS4llbDClGjxL4rp2s06em1kY iH8rR2DAzH0QXDiMfj4VHs03rvP21Bx3N6CaQXFOjeoxgcs2xTeQZXQzb68Z/9P1D2HK pIz2Dl3O7BFr1x0pYJgu6xajOzhOIrdi1UskiJ6el6UEMLn5wbLQbDgoGoXOMcUX5HKK 0kqnV9z2SVgqu25S3RRJglDRkXIeulAIb6OrwHBDp5w/z/ZiTk7GNsc1sDF3dDVEH2Eb d7Rg== X-Gm-Message-State: AOAM530/hrTxdCwmNUSIyyhZ1xVCC7T/I6akbLbc/EavMYMpDxhva1tz So4DHjHnoElUZ/wDBRk1I16JPuw2b5lDj8fc X-Google-Smtp-Source: ABdhPJx/x2iJ9WgPRx5JiXQ4WE2XZvW9coK54ql44Nf9ntv+35bq/V3u1vNaPnEGzGBqmwxFpaSwCA== X-Received: by 2002:a05:6e02:970:: with SMTP id q16mr8878666ilt.69.1603674322147; Sun, 25 Oct 2020 18:05:22 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id a6sm5231162ili.11.2020.10.25.18.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Oct 2020 18:05:21 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Doug Anderson , patchwork@lists.ozlabs.org, Simon Glass Subject: [PATCH v2 23/30] patman: Don't ignore lines starting with hash Date: Sun, 25 Oct 2020 19:04:35 -0600 Message-Id: <20201026010442.1606893-24-sjg@chromium.org> X-Mailer: git-send-email 2.29.0.rc2.309.g374f81d7ae-goog In-Reply-To: <20201026010442.1606893-1-sjg@chromium.org> References: <20201026010442.1606893-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean These lines can indicate a continuation of an error and should not be ignored. Fix this. Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code") Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/checkpatch.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py index 263bac3fc90..98d962cd50d 100644 --- a/tools/patman/checkpatch.py +++ b/tools/patman/checkpatch.py @@ -95,6 +95,7 @@ def CheckPatch(fname, verbose=False, show_types=False): re_check = re.compile('CHECK:%s (.*)' % type_name) re_file = re.compile('#\d+: FILE: ([^:]*):(\d+):') re_note = re.compile('NOTE: (.*)') + re_new_file = re.compile('new file mode .*') indent = ' ' * 6 for line in result.stdout.splitlines(): if verbose: @@ -111,8 +112,10 @@ def CheckPatch(fname, verbose=False, show_types=False): # Skip lines which quote code if line.startswith(indent): continue - # Skip code quotes and # - if line.startswith('+') or line.startswith('#'): + # Skip code quotes + if line.startswith('+'): + continue + if re_new_file.match(line): continue match = re_stats_full.match(line) if not match: