diff mbox series

Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE

Message ID 20201012074750.15602-1-patrick.delaunay@st.com
State Accepted
Commit 87459da10219c284647a45bfffb620911168f911
Delegated to: Tom Rini
Headers show
Series Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE | expand

Commit Message

Patrick Delaunay Oct. 12, 2020, 7:47 a.m. UTC
Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB
storage boot initialization is correctly managed by  distro boot command
('usb_boot' defined in include/config_distro_bootcmd.h already include
the command 'usb  start').

Fixes: 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 common/Kconfig.boot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Oct. 15, 2020, 3:05 p.m. UTC | #1
On Mon, 12 Oct 2020 at 01:48, Patrick Delaunay <patrick.delaunay@st.com> wrote:
>
> Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB
> storage boot initialization is correctly managed by  distro boot command
> ('usb_boot' defined in include/config_distro_bootcmd.h already include
> the command 'usb  start').
>
> Fixes: 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  common/Kconfig.boot | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Oct. 23, 2020, 12:29 a.m. UTC | #2
On Mon, Oct 12, 2020 at 09:47:50AM +0200, Patrick Delaunay wrote:

> Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB
> storage boot initialization is correctly managed by  distro boot command
> ('usb_boot' defined in include/config_distro_bootcmd.h already include
> the command 'usb  start').
> 
> Fixes: 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/common/Kconfig.boot b/common/Kconfig.boot
index 4191bfb34d..522f5f3d6a 100644
--- a/common/Kconfig.boot
+++ b/common/Kconfig.boot
@@ -880,7 +880,7 @@  config USE_PREBOOT
 config PREBOOT
 	string "preboot default value"
 	depends on USE_PREBOOT && !USE_DEFAULT_ENV_FILE
-	default "usb start" if USB_KEYBOARD || USB_STORAGE
+	default "usb start" if USB_KEYBOARD
 	default ""
 	help
 	  This is the default of "preboot" environment variable.