[v2,01/22] log: Fix missing negation of ENOMEM

Message ID	20201010194347.90096-2-seanga2@gmail.com
State	Superseded
Delegated to:	Tom Rini
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Sean Anderson <seanga2@gmail.com> To: u-boot@lists.denx.de Cc: Tom Rini <trini@konsulko.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <sjg@chromium.org>, Sean Anderson <seanga2@gmail.com> Subject: [PATCH v2 01/22] log: Fix missing negation of ENOMEM Date: Sat, 10 Oct 2020 15:43:26 -0400 Message-Id: <20201010194347.90096-2-seanga2@gmail.com> In-Reply-To: <20201010194347.90096-1-seanga2@gmail.com> References: <20201010194347.90096-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	log: Add commands for manipulating filters \| expand [v2,00/22] log: Add commands for manipulating filters [v2,01/22] log: Fix missing negation of ENOMEM [v2,02/22] log: Fix incorrect documentation of log_filter.cat_list [v2,03/22] log: Add additional const qualifier to arrays [v2,04/22] log: Add new category names to log_cat_name [v2,05/22] log: Use CONFIG_IS_ENABLED() for LOG_TEST [v2,06/22] log: Expose some helper functions [v2,07/22] log: Add function to create a filter with flags [v2,08/22] log: Add filter flag to deny on match [v2,09/22] test: Add tests for LOGFF_DENY [v2,10/22] log: Add filter flag to match greater than a log level [v2,11/22] test: Add test for LOGFF_MIN [v2,12/22] cmd: log: Use sub-commands for log [v2,13/22] cmd: log: Split off log level parsing [v2,14/22] cmd: log: Move log test to end of help string [v2,15/22] cmd: log: Add commands to list categories and drivers [v2,16/22] cmd: log: Make "log level" print all log levels [v2,17/22] lib: Add getopt [v2,18/22] test: Add a test for getopt [v2,19/22] cmd: log: Add commands to manipulate filters [v2,20/22] test: Add a test for log filter-* [v2,21/22] doc: Add log kerneldocs to documentation [v2,22/22] doc: Update logging documentation

Message ID

20201010194347.90096-2-seanga2@gmail.com

State

Superseded

Delegated to:

Tom Rini

Headers

From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>,
 Simon Glass <sjg@chromium.org>, Sean Anderson <seanga2@gmail.com>
Subject: [PATCH v2 01/22] log: Fix missing negation of ENOMEM
Date: Sat, 10 Oct 2020 15:43:26 -0400
Message-Id: <20201010194347.90096-2-seanga2@gmail.com>
In-Reply-To: <20201010194347.90096-1-seanga2@gmail.com>
References: <20201010194347.90096-1-seanga2@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

log: Add commands for manipulating filters | expand

Commit Message

Sean Anderson Oct. 10, 2020, 7:43 p.m. UTC

Errors returned should be negative.

Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()")

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

(no changes since v1)

 common/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/log.c b/common/log.c
index 9a5f100da3..3f6f4bdc2a 100644
--- a/common/log.c
+++ b/common/log.c
@@ -268,7 +268,7 @@  int log_add_filter(const char *drv_name, enum log_category_t cat_list[],
 	if (file_list) {
 		filt->file_list = strdup(file_list);
 		if (!filt->file_list) {
-			ret = ENOMEM;
+			ret = -ENOMEM;
 			goto err;
 		}
 	}

[v2,01/22] log: Fix missing negation of ENOMEM

Commit Message

Patch