From patchwork Fri Oct 9 21:07:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1379847 X-Patchwork-Delegate: patrick.delaunay73@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=denx.de header.i=@denx.de header.a=rsa-sha256 header.s=phobos-20191101 header.b=S0hLcHvu; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C7LJL3Xcsz9sSG for ; Sat, 10 Oct 2020 08:07:55 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 27EE182287; Fri, 9 Oct 2020 23:07:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1602277668; bh=GsCJ5I6XsCTSv5hqpCrMMlYTfHWmP73xKQjMXXlPGvs=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=S0hLcHvuKvJQLytkMAvxKs2njBNyLHbboI2S9j8qf3FTme3j7c48iaVemztW8gvEx cIZw9Xs3tppK7qgLWa6sCukl9HeG4c1BNAX2AMJvsHW7MQOrzMJwG4ioCwKUg+w9jm uMCV+YlsmLkfCUpN7fAmzAjIuZ4O2E5TwcLI+sJBWCzraXTejwHoFHt6Z4Ksf998Sw e2XtHLebvGU+bn5YGM90EnlubaXwgzi5LnbzTCmUNWPbbt2kpryWHvYXZ7vkW1dN3/ zodfVbUxgmzuPk3o8P0dNl1PJH7+QjyH0IbUdxB3k3KnHQdPAZ+7JXHnSRthv9JbYD 9OUd8k3fOGbgg== Received: by phobos.denx.de (Postfix, from userid 109) id 794AF8233D; Fri, 9 Oct 2020 23:07:46 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 35880821ED for ; Fri, 9 Oct 2020 23:07:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=marex@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C7LHx1fX0z1rwZx; Fri, 9 Oct 2020 23:07:41 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C7LHx1K6pz1qrF1; Fri, 9 Oct 2020 23:07:41 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 61Ke021ZIQm3; Fri, 9 Oct 2020 23:07:40 +0200 (CEST) X-Auth-Info: QlAu9LDQ8RUWkxty7I/lVOtMSSyDN9lkOoK1pZUpABI= Received: from desktop.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 9 Oct 2020 23:07:40 +0200 (CEST) From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Patrice Chotard , Patrick Delaunay Subject: [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus Date: Fri, 9 Oct 2020 23:07:35 +0200 Message-Id: <20201009210735.243532-1-marex@denx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The default state of SD bus and clock line is logical HI. SD card IO is open-drain and pulls the bus lines LO. Always enable the SD bus pull ups to guarantee this behavior. Note that on systems with bus voltage level shifter on the SD bus, the pull ups might also be built into the level shifter, however that should have no negative impact. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- arch/arm/dts/stm32mp15-pinctrl.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/dts/stm32mp15-pinctrl.dtsi b/arch/arm/dts/stm32mp15-pinctrl.dtsi index 154832983c..2f8ff44a7a 100644 --- a/arch/arm/dts/stm32mp15-pinctrl.dtsi +++ b/arch/arm/dts/stm32mp15-pinctrl.dtsi @@ -1184,13 +1184,13 @@ ; /* SDMMC1_CMD */ slew-rate = <1>; drive-push-pull; - bias-disable; + bias-pull-up; }; pins2 { pinmux = ; /* SDMMC1_CK */ slew-rate = <2>; drive-push-pull; - bias-disable; + bias-pull-up; }; }; @@ -1340,13 +1340,13 @@ ; /* SDMMC2_CMD */ slew-rate = <1>; drive-push-pull; - bias-disable; + bias-pull-up; }; pins2 { pinmux = ; /* SDMMC2_CK */ slew-rate = <2>; drive-push-pull; - bias-disable; + bias-pull-up; }; };