| Message ID | 20200929195212.58695-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 8bb7496ef9188493b548ceb03b741b8f6465c339 |
| Delegated to: | Andes |
| Headers | show |
| Series | [1/1] clk: kendryte: no need to check argument of free() | expand |
On 9/29/20 3:52 PM, Heinrich Schuchardt wrote: > free() checks if its argument is NULL. No need to check it twice. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/clk/kendryte/clk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/kendryte/clk.c b/drivers/clk/kendryte/clk.c > index 981b3b7699..26139fd804 100644 > --- a/drivers/clk/kendryte/clk.c > +++ b/drivers/clk/kendryte/clk.c > @@ -471,8 +471,7 @@ cleanup_gate: > cleanup_div: > free(div); > cleanup_mux: > - if (mux) > - free(mux); > + free(mux); > return comp; > } > > -- > 2.28.0 > LGTM Reviewed-by: Sean Anderson <seanga2@gmail.com>
diff --git a/drivers/clk/kendryte/clk.c b/drivers/clk/kendryte/clk.c index 981b3b7699..26139fd804 100644 --- a/drivers/clk/kendryte/clk.c +++ b/drivers/clk/kendryte/clk.c @@ -471,8 +471,7 @@ cleanup_gate: cleanup_div: free(div); cleanup_mux: - if (mux) - free(mux); + free(mux); return comp; }
free() checks if its argument is NULL. No need to check it twice. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/clk/kendryte/clk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.28.0