Message ID | 20200928042611.1696178-7-sjg@chromium.org |
---|---|
State | Superseded |
Delegated to: | Bin Meng |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=WYD4R+Y6; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C08dL5wt8z9sSn for <incoming@patchwork.ozlabs.org>; Mon, 28 Sep 2020 14:27:50 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B42A3823CA; Mon, 28 Sep 2020 06:26:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="WYD4R+Y6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8397782359; Mon, 28 Sep 2020 06:26:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 470E68237C for <u-boot@lists.denx.de>; Mon, 28 Sep 2020 06:26:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-ot1-x341.google.com with SMTP id m13so8366718otl.9 for <u-boot@lists.denx.de>; Sun, 27 Sep 2020 21:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iuckRRSFY7KUG+2f1ysMd0zQO9OWRgtJBdG1yiy4/CE=; b=WYD4R+Y6qK+KnqmXFm64CHd0jHgHVYLgPkp/IgQUFNKOw7FDvJmXPNlSiI+xU0rg3x 4CZ+cbHG7Cbih94YhrEm2yQyv031ca8lEzQ6D6FjIfnOheDsEjjPqP42Urw6zNr3bmMM bi9oHQivoa6KbsoKKBhVkRyFciXVc8sWxpllg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iuckRRSFY7KUG+2f1ysMd0zQO9OWRgtJBdG1yiy4/CE=; b=I6f6II8qAnUJQV4XHPhaV0kSxbsYI07CK3WQUVnoJlVVVllctZ+OS747ApEyRdIkd9 itzATlod06SmgiaIs5v6colyrZPoBksJGQOU7S49163QGu232u+d2J2yambAlY6vcgJb 9HDTejoUVgWdlT6IRM3Uls84OcjL7DlgxMdD720Gm3n+31Q3UoPCIBfxQxbj7+xFZBOD URdyVE5/ttBEGUL/+g5ox6rCPZ5Pwsp3f2xVWiWF94crVbmFAXrsSyLOn+FKGP0y7Nnt zC5j9FCfzWKErqOptTmC1qxN5IU0avv1Fxyt2q4FBwSzL2fuhJ9Wf14rHPf+I7tKY6s6 x8tw== X-Gm-Message-State: AOAM53195LOgGz+hnCEZmVCBoB9c0NiB6+JBnj/ZPIhK7DEcb3K82OLm 6lm9/fyV9tjGUGDJNyPI2j2hlkSDHYeJqTlu X-Google-Smtp-Source: ABdhPJyO6VrEwSjXyztkeQ70A41oZ0ANMLP/pxSzuHOG74llsbLA9CokAmGOmyEW+W5em6LxyPW3ew== X-Received: by 2002:a9d:50a:: with SMTP id 10mr7285064otw.207.1601267186036; Sun, 27 Sep 2020 21:26:26 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id k51sm2620579otc.46.2020.09.27.21.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 21:26:25 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, Bernhard Messerklinger <bernhard.messerklinger@br-automation.com>, Wolfgang Wallner <wolfgang.wallner@br-automation.com>, Walter Lozano <walter.lozano@collabora.com>, Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com> Subject: [PATCH 08/32] x86: Don't bother clearing global NVS Date: Sun, 27 Sep 2020 22:25:47 -0600 Message-Id: <20200928042611.1696178-7-sjg@chromium.org> X-Mailer: git-send-email 2.28.0.681.g6f77f65b4e-goog In-Reply-To: <20200928042611.1696178-1-sjg@chromium.org> References: <20200928042611.1696178-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean |
Series |
x86: Allow Coral to boot into Chrome OS
|
expand
|
On Mon, Sep 28, 2020 at 12:26 PM Simon Glass <sjg@chromium.org> wrote: > > The bloblist guarantees that blobs are zeroed so there is no need to do > an additional memset(). Drop it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/intel_common/acpi.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/arch/x86/cpu/intel_common/acpi.c b/arch/x86/cpu/intel_common/acpi.c index 42f87165f0c..9b183d66ae9 100644 --- a/arch/x86/cpu/intel_common/acpi.c +++ b/arch/x86/cpu/intel_common/acpi.c @@ -202,7 +202,6 @@ int southbridge_inject_dsdt(const struct udevice *dev, struct acpi_ctx *ctx) (void **)&gnvs); if (ret) return log_msg_ret("bloblist", ret); - memset(gnvs, '\0', sizeof(*gnvs)); ret = acpi_create_gnvs(gnvs); if (ret)
The bloblist guarantees that blobs are zeroed so there is no need to do an additional memset(). Drop it. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/intel_common/acpi.c | 1 - 1 file changed, 1 deletion(-)