From patchwork Mon Sep 28 00:46:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1372211 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=lJVC6jeW; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C03lG4742z9sSs for ; Mon, 28 Sep 2020 10:47:38 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53FB482380; Mon, 28 Sep 2020 02:46:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="lJVC6jeW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D18958236C; Mon, 28 Sep 2020 02:46:40 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A593982353 for ; Mon, 28 Sep 2020 02:46:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-ot1-x342.google.com with SMTP id 95so7976552ota.13 for ; Sun, 27 Sep 2020 17:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y9ETTssFWFKcbRNmIv4+9tnul6pVq0YyYc3vVLO7bos=; b=lJVC6jeWOWS5uFAnpPhHP5sPBIQlYSG+qXwJAEvwNefM6MM28Y/r26hBy0PwDgsd+d /KEDW+BQIAHBOPqM08YJq0FESR1IvCT8d77yf33T41Q/1gAC+Hdjvu6kjN1z8f51tA2y Ys0KgARJpZE6syHWKmJfRzEdEAwFprTRmUp04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y9ETTssFWFKcbRNmIv4+9tnul6pVq0YyYc3vVLO7bos=; b=lIP9Al8cMM/DqCjB6EBWM+8u1DwaCxiVV8hKD+jaafEr/CQX9QxHApNbZpjwHCUMPH FeeDOUluSHy7enZb3V8mcvrsCSPQS9sZtxK36J4CJxU7LkQsaXBshYQbi9KkpGtnb/Ki zfG+8k8l8aWGHLzpUQRg6+GZemADKkCo0Jf/liV3jY5h1rhfiVInxZJK1UlcSvt5TLsO AEMqhpxyw7hwDV2YUh0+10hJ2sEw3JalQC/Pd2ZRqoCTWSuLfeZWr+cQOEr99wRdic2+ mnDoFxoppk/VbZ26KX8SSXuYEz/I51jS6Uh/TRhrejqxMCKPaUD/ta33hR+u/gyEzKgG Vc8Q== X-Gm-Message-State: AOAM533MWyr2DV0aFFdzaKhf63HM4OCsIYiLODDR/vaPjixwLxLc4vzD fuSK5cLt2T7WOYYMpwjtcTI7tpEAGN2lnsOG X-Google-Smtp-Source: ABdhPJw+0i6XxIT64DGCrNhG1zipo87fe5SIVE25Vu+EDZGosVMi7RrxQAm3swfWkQoynnTU4zaQWg== X-Received: by 2002:a9d:61d5:: with SMTP id h21mr7416977otk.187.1601253995307; Sun, 27 Sep 2020 17:46:35 -0700 (PDT) Received: from localhost.localdomain (c-73-14-175-90.hsd1.co.comcast.net. [73.14.175.90]) by smtp.gmail.com with ESMTPSA id t7sm1790995ooq.0.2020.09.27.17.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 17:46:34 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Simon Glass Subject: [PATCH 05/12] syscon: Drop the logging in syscon_get_by_driver_data() Date: Sun, 27 Sep 2020 18:46:17 -0600 Message-Id: <20200928004624.1652803-6-sjg@chromium.org> X-Mailer: git-send-email 2.28.0.681.g6f77f65b4e-goog In-Reply-To: <20200928004624.1652803-1-sjg@chromium.org> References: <20200928004624.1652803-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean This function can be called when it is not known whether it will find anything. This results in confusing log messages if the device is not found. It is better for the caller to log the failure, if necessary. Drop the logging from this function. Signed-off-by: Simon Glass --- drivers/core/syscon-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/syscon-uclass.c b/drivers/core/syscon-uclass.c index 9cbda4ebdae..66ac579e465 100644 --- a/drivers/core/syscon-uclass.c +++ b/drivers/core/syscon-uclass.c @@ -140,7 +140,7 @@ int syscon_get_by_driver_data(ulong driver_data, struct udevice **devp) ret = uclass_first_device_drvdata(UCLASS_SYSCON, driver_data, devp); if (ret) - return log_msg_ret("find", ret); + return ret; return 0; }