From patchwork Tue Sep 1 20:07:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1355342 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=N0zaFcQe; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bgyp766D8z9sTh for ; Wed, 2 Sep 2020 06:09:19 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A089822CA; Tue, 1 Sep 2020 22:08:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N0zaFcQe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 325F5822B4; Tue, 1 Sep 2020 22:08:21 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7EAE382284 for ; Tue, 1 Sep 2020 22:08:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x742.google.com with SMTP id p25so2239383qkp.2 for ; Tue, 01 Sep 2020 13:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JrreX9iKyIbdO+4gya0cpRD1pcSsa4XSaa270bO8Ico=; b=N0zaFcQeahPdbI+TKfonaVGZSBp1WmeSHoLgL/TNCEqGIupxZXSH6ZUklXtH8BAZR1 MCTwLN6g71OPlTLolXDmq2XodD+ApExm6eBp3U+Bv3bWmzY+67bDfwoWP/1D/IXBMTPD i7CZeBKW/88bxuJipq8wgtfuEL4ytMua4LFl9pHBWOJK8XxJJrmpXp+oncrJ3CAdaO3L cqlwXF0rSR5tpJ4rPpkxdmu7q3wLhz/5q6X2Ci59BqxojyKEblqactTcL6d+GpC/Equ1 EUiq6eD4qQ92o1aRVH5xHE0V0UhMVtSQK0I1XDBXO6WHyUAOiDikQQUkAwDEgpsVw/Cn Y43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JrreX9iKyIbdO+4gya0cpRD1pcSsa4XSaa270bO8Ico=; b=gDyytQevYrcEtT5nDN278Emdf2+ykclrA5DK/o3mO5ziOWfWKk7yIHCL5ogqHoCEZL 5XsHjvxLHMSv/CLosW58a231onb/anW4QDO17EOgtWeaGPwjnQupOVamkNIyNp0tGKPZ YfIQuE5/moBiyiDqStVA79Fme4r6FdZQ887ACsCXO16K3hm2MFvvFrAmX5O7soJBgob4 mcH5pmNdSNv+1F3aJHsSIvUgJTi736bNrrOai/0jZuXiko+NbDGwrjdOSRsfdMQeXJ0x 6zi9/hUarhuh0Ogo4rg0h/Vu5yfG+kP70FxD3BzUCNXaJTu7XJCzBcXCHSkdOSyo0h77 8HsA== X-Gm-Message-State: AOAM533d6tIMQv1ISo4DwU03zINVddjq4K0amWZAm3jk2Cag06KC2sRE /IXGmLX8nz5ML6r4FhvTr5iM6xZdvW5Kni0S X-Google-Smtp-Source: ABdhPJwJ9RLiGz5ysWoIewLDTlrc59IRKVeAv5zXcxy3PXdJyeT5SZ4om0Sx6qpB1MSVMUEHfZ8TDA== X-Received: by 2002:a37:a514:: with SMTP id o20mr3588498qke.374.1598990896724; Tue, 01 Sep 2020 13:08:16 -0700 (PDT) Received: from godwin.fios-router.home (pool-108-51-35-162.washdc.fios.verizon.net. [108.51.35.162]) by smtp.gmail.com with ESMTPSA id y24sm2545039qtv.71.2020.09.01.13.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 13:08:16 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de Cc: Bin Meng , Heinrich Schuchardt , Jagan Teki , Simon Glass , Marek Vasut , Sean Anderson Subject: [PATCH v3 4/7] wdt: dw: Enable the clock before using it Date: Tue, 1 Sep 2020 16:07:55 -0400 Message-Id: <20200901200758.543851-5-seanga2@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901200758.543851-1-seanga2@gmail.com> References: <20200901200758.543851-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean The watchdog won't work if the clock isn't enabled. Fixes: cf89ef8d10f240554541c20b2e1bdcdd58d1d7e6 Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) drivers/watchdog/designware_wdt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/watchdog/designware_wdt.c b/drivers/watchdog/designware_wdt.c index 41866fa01b..e6f5437056 100644 --- a/drivers/watchdog/designware_wdt.c +++ b/drivers/watchdog/designware_wdt.c @@ -129,6 +129,10 @@ static int designware_wdt_probe(struct udevice *dev) if (ret) return ret; + ret = clk_enable(&clk); + if (ret) + return ret; + priv->clk_khz = clk_get_rate(&clk) / 1000; if (!priv->clk_khz) return -EINVAL;