| Message ID | 20200822204536.63827-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | 43e2d1dd47a7e9b126659dc17a10f351e49bc53b |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | ARM: dts: stm32: Pull UART4 RX high on AV96 | expand |
On 8/22/20 10:45 PM, Marek Vasut wrote: > There is no dedicated pull resistor on the AV96 UART4 (console UART) > pin. In case there is no UART adapter installed on the AV96, the line > is floating and can trigger reception of garbage characters, which in > turn can abort U-Boot autoboot. Add default pull up to mitigate this > problem. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> Bump, also AV96 PLL4.
Hi Marek, > From: Marek Vasut <marex@denx.de> > Sent: samedi 22 août 2020 22:46 > > There is no dedicated pull resistor on the AV96 UART4 (console UART) pin. In > case there is no UART adapter installed on the AV96, the line is floating and can > trigger reception of garbage characters, which in turn can abort U-Boot autoboot. > Add default pull up to mitigate this problem. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > --- > arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > index cb92fc9c14..1ae57e1854 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi > @@ -75,6 +75,8 @@ > }; > pins2 { > u-boot,dm-pre-reloc; > + /delete-property/ bias-disable; > + bias-pull-up; > }; > }; > > -- > 2.28.0 Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com> Applied to u-boot-stm/master, thanks! Thanks Patrick
diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi index cb92fc9c14..1ae57e1854 100644 --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi @@ -75,6 +75,8 @@ }; pins2 { u-boot,dm-pre-reloc; + /delete-property/ bias-disable; + bias-pull-up; }; };
There is no dedicated pull resistor on the AV96 UART4 (console UART) pin. In case there is no UART adapter installed on the AV96, the line is floating and can trigger reception of garbage characters, which in turn can abort U-Boot autoboot. Add default pull up to mitigate this problem. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Patrick Delaunay <patrick.delaunay@st.com> Cc: Patrice Chotard <patrice.chotard@st.com> --- arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 2 ++ 1 file changed, 2 insertions(+)