diff mbox series

[v1,09/15] x86: intel: cougarcanyon2: Remove dead code

Message ID 20200806145438.65862-9-andriy.shevchenko@linux.intel.com
State Superseded
Delegated to: Bin Meng
Headers show
Series [v1,01/15] x86: Introduce USE_EARLY_BOARD_INIT option | expand

Commit Message

Andy Shevchenko Aug. 6, 2020, 2:54 p.m. UTC 
start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply drop the rule from it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 board/intel/cougarcanyon2/Makefile | 2 +-
 board/intel/cougarcanyon2/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/cougarcanyon2/start.S

Comments

Simon Glass Aug. 16, 2020, 3:39 a.m. UTC | #1 
On Thu, 6 Aug 2020 at 08:54, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply drop the rule from it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  board/intel/cougarcanyon2/Makefile | 2 +-
>  board/intel/cougarcanyon2/start.S  | 8 --------
>  2 files changed, 1 insertion(+), 9 deletions(-)
>  delete mode 100644 board/intel/cougarcanyon2/start.S

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/board/intel/cougarcanyon2/Makefile b/board/intel/cougarcanyon2/Makefile
index 75cc508f4ec0..13b19ae65389 100644
--- a/board/intel/cougarcanyon2/Makefile
+++ b/board/intel/cougarcanyon2/Makefile
@@ -2,4 +2,4 @@ 
 #
 # Copyright (C) 2016, Bin Meng <bmeng.cn@gmail.com>
 
-obj-y	+= cougarcanyon2.o start.o
+obj-y	+= cougarcanyon2.o
diff --git a/board/intel/cougarcanyon2/start.S b/board/intel/cougarcanyon2/start.S
deleted file mode 100644
index 8521800921e4..000000000000
--- a/board/intel/cougarcanyon2/start.S
+++ /dev/null
@@ -1,8 +0,0 @@ 
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2016, Bin Meng <bmeng.cn@gmail.com>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret