| Message ID | 20200806145438.65862-4-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [v1,01/15] x86: Introduce USE_EARLY_BOARD_INIT option | expand |
On Thu, 6 Aug 2020 at 08:54, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > start.S does nothing and can be safely removed. Makefile is still being used > by the build system, so simply drop the rule from it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > board/coreboot/coreboot/Makefile | 2 +- > board/coreboot/coreboot/start.S | 12 ------------ > 2 files changed, 1 insertion(+), 13 deletions(-) > delete mode 100644 board/coreboot/coreboot/start.S > Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/board/coreboot/coreboot/Makefile b/board/coreboot/coreboot/Makefile index 8db7cc62f309..d292b7032c23 100644 --- a/board/coreboot/coreboot/Makefile +++ b/board/coreboot/coreboot/Makefile @@ -10,4 +10,4 @@ # (C) Copyright 2002 # Daniel Engström, Omicron Ceti AB, daniel@omicron.se. -obj-y += start.o coreboot.o +obj-y += coreboot.o diff --git a/board/coreboot/coreboot/start.S b/board/coreboot/coreboot/start.S deleted file mode 100644 index aa702622d48c..000000000000 --- a/board/coreboot/coreboot/start.S +++ /dev/null @@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * (C) Copyright 2008 - * Graeme Russ, graeme.russ@gmail.com. - */ - -/* board early intialization */ -.globl early_board_init -early_board_init: - /* No 32-bit board specific initialisation */ - jmp early_board_init_ret
start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- board/coreboot/coreboot/Makefile | 2 +- board/coreboot/coreboot/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/coreboot/coreboot/start.S