diff mbox series

[v1,02/15] x86: advantech: som-db5800-som-6867: Remove dead code

Message ID 20200806145438.65862-2-andriy.shevchenko@linux.intel.com
State Superseded
Delegated to: Bin Meng
Headers show
Series [v1,01/15] x86: Introduce USE_EARLY_BOARD_INIT option | expand

Commit Message

Andy Shevchenko Aug. 6, 2020, 2:54 p.m. UTC
start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply drop the rule from it.

Cc: George McCollister <george.mccollister@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 board/advantech/som-db5800-som-6867/Makefile | 2 +-
 board/advantech/som-db5800-som-6867/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/advantech/som-db5800-som-6867/start.S

Comments

Simon Glass Aug. 16, 2020, 3:39 a.m. UTC | #1
On Thu, 6 Aug 2020 at 08:54, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply drop the rule from it.
>
> Cc: George McCollister <george.mccollister@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  board/advantech/som-db5800-som-6867/Makefile | 2 +-
>  board/advantech/som-db5800-som-6867/start.S  | 8 --------
>  2 files changed, 1 insertion(+), 9 deletions(-)
>  delete mode 100644 board/advantech/som-db5800-som-6867/start.S
>

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/board/advantech/som-db5800-som-6867/Makefile b/board/advantech/som-db5800-som-6867/Makefile
index 0524766bb718..7975547f4109 100644
--- a/board/advantech/som-db5800-som-6867/Makefile
+++ b/board/advantech/som-db5800-som-6867/Makefile
@@ -2,5 +2,5 @@ 
 #
 # Copyright (C) 2015, Google, Inc
 
-obj-y	+= som-db5800-som-6867.o start.o
+obj-y	+= som-db5800-som-6867.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
diff --git a/board/advantech/som-db5800-som-6867/start.S b/board/advantech/som-db5800-som-6867/start.S
deleted file mode 100644
index 65d1f7e96150..000000000000
--- a/board/advantech/som-db5800-som-6867/start.S
+++ /dev/null
@@ -1,8 +0,0 @@ 
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret