Message ID | 20200729023538.8089-1-wig.cheng@technexion.com |
---|---|
State | Changes Requested |
Delegated to: | Stefano Babic |
Headers | show |
Series | None | expand |
On Tue, Jul 28, 2020 at 11:35 PM <wig.cheng@technexion.com> wrote: > > From: Wig Cheng <wig.cheng@technexion.com> > > Fix compile warning messages. > > Signed-off-by: Wig Cheng <wig.cheng@technexion.com> > --- > configs/pico-imx6ul_defconfig | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configs/pico-imx6ul_defconfig b/configs/pico-imx6ul_defconfig > index e8cbf3bc1e..f02d370b7d 100644 > --- a/configs/pico-imx6ul_defconfig > +++ b/configs/pico-imx6ul_defconfig > @@ -75,4 +75,8 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL" > CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > CONFIG_CI_UDC=y > -CONFIG_VIDEO=y > +CONFIG_DM_VIDEO=y > +CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0 Why is this one needed?
On Tue, Jul 28, 2020 at 11:35 PM <wig.cheng@technexion.com> wrote: > > From: Wig Cheng <wig.cheng@technexion.com> > > Fix compile warning messages. One more thing: you did a good job in writing the commit logs for the other patches, but this one needs to be improved.
On 7/30/20 9:15 AM, Fabio Estevam wrote: > On Tue, Jul 28, 2020 at 11:35 PM <wig.cheng@technexion.com> wrote: >> From: Wig Cheng <wig.cheng@technexion.com> >> >> Fix compile warning messages. >> >> Signed-off-by: Wig Cheng <wig.cheng@technexion.com> >> --- >> configs/pico-imx6ul_defconfig | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/configs/pico-imx6ul_defconfig b/configs/pico-imx6ul_defconfig >> index e8cbf3bc1e..f02d370b7d 100644 >> --- a/configs/pico-imx6ul_defconfig >> +++ b/configs/pico-imx6ul_defconfig >> @@ -75,4 +75,8 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL" >> CONFIG_USB_GADGET_VENDOR_NUM=0x0525 >> CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 >> CONFIG_CI_UDC=y >> -CONFIG_VIDEO=y >> +CONFIG_DM_VIDEO=y >> +CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0 > Why is this one needed? It shows warning messages after compiled: ===================== WARNING ====================== This board does not use CONFIG_DM_VIDEO Please update the board to use CONFIG_DM_VIDEO before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== Enable DM_VIDEO will be solved this warning although there's no difference no matter enable DM_VIDEO or not on runtime level, just for warning message. I'll improve the commit log if you think it's okay, thanks a lot.
On Wed, Jul 29, 2020 at 11:21 PM wig <wig.cheng@technexion.com> wrote: > It shows warning messages after compiled: > > ===================== WARNING ====================== > This board does not use CONFIG_DM_VIDEO Please update > the board to use CONFIG_DM_VIDEO before the v2019.07 release. > Failure to update by the deadline may result in board removal. > See doc/driver-model/migration.rst for more info. > ==================================================== > > Enable DM_VIDEO will be solved this warning although there's no > difference no matter enable DM_VIDEO or not on runtime level, just for > warning message. > > I'll improve the commit log if you think it's okay, thanks a lot. Yes, with the improved commit log and removing CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0 the patch will be good. Thanks
diff --git a/configs/pico-imx6ul_defconfig b/configs/pico-imx6ul_defconfig index e8cbf3bc1e..f02d370b7d 100644 --- a/configs/pico-imx6ul_defconfig +++ b/configs/pico-imx6ul_defconfig @@ -75,4 +75,8 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y +CONFIG_VIDEO_PCI_DEFAULT_FB_SIZE=0x0 +# CONFIG_CMD_VIDCONSOLE is not set +# CONFIG_VIDEO_BPP8 is not set +# CONFIG_VIDEO_BPP16 is not set