diff mbox series

[v1] configs: pico-imx6: convert ethernet function to DM_ETH

Message ID 20200728103744.11626-1-wig.cheng@technexion.com
State Accepted
Commit 3e980a2d8bd13d0d1c2d5cec9e57a47b6cff8b92
Delegated to: Stefano Babic
Headers show
Series [v1] configs: pico-imx6: convert ethernet function to DM_ETH | expand

Commit Message

wig July 28, 2020, 10:37 a.m. UTC 
From: Wig Cheng <wig.cheng@technexion.com>

Before enable _DM_ETH:
    Net:   FEC [PRIME]

After enable DM_ETH:
    Net:   eth0: ethernet@2188000

Here is the test commands:
    => dhcp
    BOOTP broadcast 1
    DHCP client bound to address 10.88.88.152 (146 ms)
    *** ERROR: `serverip' not set
    Cannot autoload with TFTPGET
    => ping 8.8.8.8
    Using ethernet@2188000 device
    host 8.8.8.8 is alive

Signed-off-by: Wig Cheng <wig.cheng@technexion.com>
---
 configs/pico-imx6_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Fabio Estevam July 28, 2020, 12:42 p.m. UTC | #1 
HI Wig,

On Tue, Jul 28, 2020 at 7:37 AM <wig.cheng@technexion.com> wrote:
>
> From: Wig Cheng <wig.cheng@technexion.com>
>
> Before enable _DM_ETH:
>     Net:   FEC [PRIME]
>
> After enable DM_ETH:
>     Net:   eth0: ethernet@2188000
>
> Here is the test commands:
>     => dhcp
>     BOOTP broadcast 1
>     DHCP client bound to address 10.88.88.152 (146 ms)
>     *** ERROR: `serverip' not set
>     Cannot autoload with TFTPGET
>     => ping 8.8.8.8
>     Using ethernet@2188000 device
>     host 8.8.8.8 is alive
>
> Signed-off-by: Wig Cheng <wig.cheng@technexion.com>
> ---
>  configs/pico-imx6_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configs/pico-imx6_defconfig b/configs/pico-imx6_defconfig
> index 04c132b474..5fe2850086 100644
> --- a/configs/pico-imx6_defconfig
> +++ b/configs/pico-imx6_defconfig
> @@ -64,6 +64,9 @@ CONFIG_DM_MMC=y
>  CONFIG_FSL_USDHC=y
>  CONFIG_PHYLIB=y
>  CONFIG_PHY_ATHEROS=y
> +CONFIG_DM_ETH=y
> +CONFIG_DM_MDIO=y

mx6 has only a single FEC instance, so there is no need for selecting DM_MDIO.

Please see this patch I have recently submitted:
https://gitlab.denx.de/u-boot/custodians/u-boot-imx/-/commit/45032991194239991726cafe4dfa6a72ddf45956

Other than that your patch looks good.
diff mbox series

Patch

diff --git a/configs/pico-imx6_defconfig b/configs/pico-imx6_defconfig
index 04c132b474..5fe2850086 100644
--- a/configs/pico-imx6_defconfig
+++ b/configs/pico-imx6_defconfig
@@ -64,6 +64,9 @@  CONFIG_DM_MMC=y
 CONFIG_FSL_USDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_RGMII=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_MXC_UART=y