diff mbox series

[v2,1/2] mtd: nand: raw: denali: Assert reset before deassert

Message ID 20200710065816.60312-1-ley.foon.tan@intel.com
State Accepted
Commit 3e57f879eee61df88c17ca447f1a9f6d7e598cde
Delegated to: Simon Goldschmidt
Headers show
Series [v2,1/2] mtd: nand: raw: denali: Assert reset before deassert | expand

Commit Message

Ley Foon Tan July 10, 2020, 6:58 a.m. UTC 
Always put the controller in reset, then take it out of reset.
This is to make sure controller always in reset state in both SPL and
proper Uboot.

This is preparation for the next patch to poll for reset completion
(rst_comp) bit after reset.

Tested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Radu Bacrau <radu.bacrau@intel.com>
Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>

---
v2:
- Added "Tested-by" in commit message.
---
 drivers/mtd/nand/raw/denali_dt.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Masahiro Yamada July 10, 2020, 1:06 p.m. UTC | #1 
On Fri, Jul 10, 2020 at 3:58 PM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>
> Always put the controller in reset, then take it out of reset.
> This is to make sure controller always in reset state in both SPL and
> proper Uboot.
>
> This is preparation for the next patch to poll for reset completion
> (rst_comp) bit after reset.
>
> Tested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Radu Bacrau <radu.bacrau@intel.com>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>


I will include this in my next pull request.

Applied.
Thanks.
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/denali_dt.c b/drivers/mtd/nand/raw/denali_dt.c
index 2728e8098faa..75ad15b0758c 100644
--- a/drivers/mtd/nand/raw/denali_dt.c
+++ b/drivers/mtd/nand/raw/denali_dt.c
@@ -148,6 +148,8 @@  static int denali_dt_probe(struct udevice *dev)
 	if (ret) {
 		dev_warn(dev, "Can't get reset: %d\n", ret);
 	} else {
+		reset_assert_bulk(&resets);
+		udelay(2);
 		reset_deassert_bulk(&resets);
 
 		/*