From patchwork Mon Jun 29 09:47:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318806 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=qMh9c58G; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN5n2T5Bz9sQx for ; Mon, 29 Jun 2020 19:50:37 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6D59A81FE2; Mon, 29 Jun 2020 11:48:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="qMh9c58G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0960A81FB9; Mon, 29 Jun 2020 11:48:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E3E881F75 for ; Mon, 29 Jun 2020 11:48:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkuXkF+OhZJS2QTTbCOnxhD0NurJG3sMGo45ncAnuYaFPxTRKQKgRGlGtcLJl/On9ubHiiRUQZkoaF0b19czL4S7LxgXVNRnDKJdR5NJ7269GH+iqRj4ucWWXi9V97xghOnFe+cvxsGPHjmwm7uTtvzGARRE20En5KV8eKvFeo0eqRMrRLsNC/tC5WcXBUnBzBE4DUT6K4xwKoEkFhzuKNGc4QXiJJibnSQI3jQs0dKGy6R+D16+FWbjEckMYeQciRRms1aoEgzDejiQa+wkxcVpzXdGJS+MOiYcmNDmF7ccXHHvI/hTXEflgTHjNkA2qpQVS2OwbiRv0ysWhrfsNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gdSIoIfyjDGTdC41kpuJBlYZ7CTs6NKsTgvfhMTOkGE=; b=dzs3thSxJb3UIpOZNNJK0ncvrKnRgVFOXsgM11wLPkRug+n0eaEhp60Vki4yUYO60WPJA73tquGGc3juwguPD0CWIcvxy2KqVvViqbl618pIdjsPEW+gBORfgRe8aTSuoGInSXZ+asICW+Hyz9eqmZqXTXKUbLSKic2A7PstsCGxG+szEE8zGYTTOlxovYVWcqtmoyEyEsIMo4re000U7Qi/ArfnAwRPUwD5QR/22T+TZGX8M6uZasD7HkPbgJRLdEaS1yZvoBP8rVT1NdGCGGkpwAEMZ8kSqouTCkxYrSUVAhaIeFEfkon12EUY3aNauDI3cE7F6l/6M/89Mzd80w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gdSIoIfyjDGTdC41kpuJBlYZ7CTs6NKsTgvfhMTOkGE=; b=qMh9c58G6BG83oRfbivzKhEfsqLstv5eHVgW6PQFeXt/xBlnmRtT8W0tHwpqjtlIQUhAmzHYXubgSE/KYMP95RX7Iwe68CheCok5+evK5fxugdGzmTTf4+jnZ36D6vHmSMeBY+oJtMkGuu10VvDV6g5guoABqkpY0RkeQuEVs0c= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB4038.namprd13.prod.outlook.com (2603:10b6:208:26a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.14; Mon, 29 Jun 2020 09:48:16 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:16 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 6/6] mmc_spi: generate R1b response for erase and stop transmission command Date: Mon, 29 Jun 2020 15:17:29 +0530 Message-Id: <20200629094730.10051-7-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:48:13 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8004391-be6e-46e4-cd64-08d81c118ba2 X-MS-TrafficTypeDiagnostic: MN2PR13MB4038: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:316; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVroFfR1pode2n+KLdL0ufufVzXJIq+Ni4L77WGYWAn+x73dtBC7mwzBd0KG+YAxGlVki9qWMLhISAd0d3+hjY2elMaoGnhNF4VXKlmYAIun/Y2zgRQZCHaIaVD3A6UN25m+c1xKA5Jwuh3FlcdtePHO/wGBH6BolO7ukLYZWv6AhiReh/z210CKJRh1YerZwrXDikI8XWi41bekQ5W1z8ya7xsDMJWU88D94d/1czzLoHQ8d4z79FgNEXLJfzTGktXo3nSIXb6mojlUc7qoHvqXYoF9ByKXhxHKMU/rthnZ4dXM37fUfTMGq5RJdPLg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(346002)(136003)(396003)(39840400004)(376002)(956004)(8936002)(44832011)(16526019)(478600001)(316002)(6916009)(26005)(186003)(5660300002)(4326008)(107886003)(6506007)(66556008)(52116002)(2616005)(6486002)(1076003)(2906002)(36756003)(66476007)(8676002)(86362001)(66946007)(6512007)(6666004)(1006002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 4gHNMXUvPdBhyTKZ3XC7GmE+WR0hg5EwZ03Ad9VZoGjlbsspHTFj7PXJu+SR7f4DUm8TRxkOP2FrgtZ5hpzOezr8ppE7/+dQ9ssuEWGhJ0cVtn1qQ7dODGpZ4hjm9hI9I8WvTX8cd8eiE1IleOE5AcOm09RfpKwduDqQ2rtJ+0CwkKiP404cZf8uRCwcnt6e6OUR8TNLxTN6xVtG3UBVAT0hHm/Cho30DyjiRBVRtIzGn7diyBKlRQiKXVF2zJnfozrbrsupycZOmzgSQJyzscy54bBgMRy2NjvmFz7r7sJUPLLy6PBF9mm7h6VOI5WeQWeUPov2+6LEyKHLVPqebQsYbWA9pu2h4G0U3S+IWD9YqVZk9qv1vw1ymepbodnhMrKihAeQfk58uh77/1RWUNiOndeeiHtPqVotGCJ9wUrkZs9u791p0JnziNKYAkhfxQeafqjmL9VyzFPxILWeK/VyfXhv3EyPGDjXG7Zy2+QTwCPNqzDRBBVzkWnxYwXo X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8004391-be6e-46e4-cd64-08d81c118ba2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:15.9057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q35d5Ov9geajNMUWCfNy/q3mYYmeQ1XUcbumJnlbEllrDCVkEoCWFT3zqqjcpE+G9K2uNjjCkXXMOvJzrDCCK3a4sHRTfXEq8CBpF3qLBws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4038 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean As per the SD physical layer specification version 7.10, erase command (CMD38) and stop transmission command (CMD12) will generate R1b response. R1b = R1 + busy signal A non-zero value after the R1 response indicates card is ready for next command. Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index 96a41076dc..50fcd32674 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -59,6 +59,7 @@ #define CMD_TIMEOUT 8 #define READ_TIMEOUT 3000000 /* 1 sec */ #define WRITE_TIMEOUT 3000000 /* 1 sec */ +#define R1B_TIMEOUT 3000000 /* 1 sec */ struct mmc_spi_plat { struct mmc_config cfg; @@ -72,7 +73,7 @@ struct mmc_spi_priv { static int mmc_spi_sendcmd(struct udevice *dev, ushort cmdidx, u32 cmdarg, u32 resp_type, u8 *resp, u32 resp_size, - bool resp_match, u8 resp_match_value) + bool resp_match, u8 resp_match_value, bool r1b) { int i, rpos = 0, ret = 0; u8 cmdo[7], r; @@ -133,6 +134,24 @@ static int mmc_spi_sendcmd(struct udevice *dev, resp[i] = r; } + if (r1b == true) { + i = R1B_TIMEOUT; + while (i) { + ret = dm_spi_xfer(dev, 1 * 8, NULL, &r, 0); + if (ret) + return ret; + + debug(" resp%d=0x%x", rpos, r); + rpos++; + i--; + + if (r) + break; + } + if (!i) + return -ETIMEDOUT; + } + debug("\n"); return 0; @@ -265,7 +284,7 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, int i, multi, ret = 0; u8 *resp = NULL; u32 resp_size = 0; - bool resp_match = false; + bool resp_match = false, r1b = false; u8 resp8 = 0, resp16[2] = { 0 }, resp40[5] = { 0 }, resp_match_value = 0; dm_spi_claim_bus(dev); @@ -296,12 +315,17 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, break; case MMC_CMD_SET_BLOCKLEN: case MMC_CMD_SPI_CRC_ON_OFF: - case MMC_CMD_STOP_TRANSMISSION: resp = &resp8; resp_size = sizeof(resp8); resp_match = true; resp_match_value = 0x0; break; + case MMC_CMD_STOP_TRANSMISSION: + case MMC_CMD_ERASE: + resp = &resp8; + resp_size = sizeof(resp8); + r1b = true; + break; case MMC_CMD_SEND_CSD: case MMC_CMD_SEND_CID: case MMC_CMD_READ_SINGLE_BLOCK: @@ -323,7 +347,7 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, }; ret = mmc_spi_sendcmd(dev, cmd->cmdidx, cmd->cmdarg, cmd->resp_type, - resp, resp_size, resp_match, resp_match_value); + resp, resp_size, resp_match, resp_match_value, r1b); if (ret) goto done;