| Message ID | 20200619091945.11656-1-patrick.delaunay@st.com |
|---|---|
| State | Accepted |
| Commit | 792919241b3d750cd5295dfe6dd1d0958b9be468 |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | ARM: dts: stm32: Reinstate card detect behavior on ST boards | expand |
Hi Patrick On 6/19/20 11:19 AM, Patrick Delaunay wrote: > The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far > unsupported, reinstate the old cd-gpios behavior until this handling > is fully implemented. This avoid potential issue for SDCard boot: > the card detect fails with floating gpio. > > Hi, > > I don't have boot issue on my boards (DK2 and EV1) but this > patch avoids potential issue with floating gpio as issue see > by Marek on DHSOM. > > To be reverted in v2020.10 when the serie [1] is accepted. > > The generic impacts in gpio uclass [2] is already accepted > for V2020.07 and merged in master branch. > > [1] stm32mp1: activate gpio hog support and add new pinctrl ops > http://patchwork.ozlabs.org/project/uboot/list/?series=181294 > > [2] dm: add support of new binding in gpio and pincontrol > http://patchwork.ozlabs.org/project/uboot/list/?series=152777&state=* > > Patrick > > END > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 2 ++ > arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi > index 3fedb6f1e1..e13dade463 100644 > --- a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi > @@ -171,6 +171,8 @@ > > &sdmmc1 { > u-boot,dm-spl; > + broken-cd; > + /delete-property/ cd-gpios; > }; > > &sdmmc1_b4_pins_a { > diff --git a/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi > index a07c585415..b16dc28d47 100644 > --- a/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi > @@ -167,6 +167,8 @@ > > &sdmmc1 { > u-boot,dm-spl; > + broken-cd; > + /delete-property/ cd-gpios; > }; > > &sdmmc1_b4_pins_a { Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks Patrice
Hi, > From: Patrick DELAUNAY <patrick.delaunay@st.com> > Sent: vendredi 19 juin 2020 11:20 > > The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far > unsupported, reinstate the old cd-gpios behavior until this handling is fully > implemented. This avoid potential issue for SDCard boot: > the card detect fails with floating gpio. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 2 ++ arch/arm/dts/stm32mp157c- > ed1-u-boot.dtsi | 2 ++ > 2 files changed, 4 insertions(+) > Applied to u-boot-stm/master, thanks! But I remove the Commit-note manually (error in patch sent with patman) Regards Patrick
diff --git a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi index 3fedb6f1e1..e13dade463 100644 --- a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi +++ b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi @@ -171,6 +171,8 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; }; &sdmmc1_b4_pins_a { diff --git a/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi index a07c585415..b16dc28d47 100644 --- a/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi +++ b/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi @@ -167,6 +167,8 @@ &sdmmc1 { u-boot,dm-spl; + broken-cd; + /delete-property/ cd-gpios; }; &sdmmc1_b4_pins_a {
The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This avoid potential issue for SDCard boot: the card detect fails with floating gpio. Hi, I don't have boot issue on my boards (DK2 and EV1) but this patch avoids potential issue with floating gpio as issue see by Marek on DHSOM. To be reverted in v2020.10 when the serie [1] is accepted. The generic impacts in gpio uclass [2] is already accepted for V2020.07 and merged in master branch. [1] stm32mp1: activate gpio hog support and add new pinctrl ops http://patchwork.ozlabs.org/project/uboot/list/?series=181294 [2] dm: add support of new binding in gpio and pincontrol http://patchwork.ozlabs.org/project/uboot/list/?series=152777&state=* Patrick END Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 2 ++ arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 2 ++ 2 files changed, 4 insertions(+)