| Message ID | 20200607120615.6428-1-kettenis@openbsd.org |
|---|---|
| State | Accepted |
| Commit | f808d7572392723cc2bf7ae4bbf31873572bac27 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [v3,1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399 | expand |
Hi Mark, What's the change in this new version? Thanks, - Kever On 2020/6/7 下午8:06, Mark Kettenis wrote: > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > Firefly RK3399 board. > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> > --- > configs/firefly-rk3399_defconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig > index 4c9f1e189b..5bb54f5835 100644 > --- a/configs/firefly-rk3399_defconfig > +++ b/configs/firefly-rk3399_defconfig > @@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y > CONFIG_CMD_GPT=y > CONFIG_CMD_MMC=y > CONFIG_CMD_USB=y > +CONFIG_CMD_PCI=y > # CONFIG_CMD_SETEXPR is not set > CONFIG_CMD_TIME=y > CONFIG_SPL_OF_CONTROL=y > @@ -38,10 +39,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000 > CONFIG_DM_ETH=y > CONFIG_ETH_DESIGNWARE=y > CONFIG_GMAC_ROCKCHIP=y > +CONFIG_NVME=y > +CONFIG_PCI=y > CONFIG_PMIC_RK8XX=y > CONFIG_REGULATOR_PWM=y > CONFIG_REGULATOR_RK8XX=y > CONFIG_PWM_ROCKCHIP=y > +CONFIG_DM_RESET=y > CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART_SHIFT=2 > CONFIG_SYSRESET=y
> From: Kever Yang <kever.yang@rock-chips.com> > Date: Sun, 7 Jun 2020 20:32:33 +0800 > > Hi Mark, > > What's the change in this new version? No change. Just regenerated from a clean master such that there are no conflicts when applying. > On 2020/6/7 下午8:06, Mark Kettenis wrote: > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > Firefly RK3399 board. > > > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> > > --- > > configs/firefly-rk3399_defconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig > > index 4c9f1e189b..5bb54f5835 100644 > > --- a/configs/firefly-rk3399_defconfig > > +++ b/configs/firefly-rk3399_defconfig > > @@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y > > CONFIG_CMD_GPT=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_USB=y > > +CONFIG_CMD_PCI=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_CMD_TIME=y > > CONFIG_SPL_OF_CONTROL=y > > @@ -38,10 +39,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000 > > CONFIG_DM_ETH=y > > CONFIG_ETH_DESIGNWARE=y > > CONFIG_GMAC_ROCKCHIP=y > > +CONFIG_NVME=y > > +CONFIG_PCI=y > > CONFIG_PMIC_RK8XX=y > > CONFIG_REGULATOR_PWM=y > > CONFIG_REGULATOR_RK8XX=y > > CONFIG_PWM_ROCKCHIP=y > > +CONFIG_DM_RESET=y > > CONFIG_BAUDRATE=1500000 > > CONFIG_DEBUG_UART_SHIFT=2 > > CONFIG_SYSRESET=y > > >
Hi Mark, On 2020/6/7 下午8:44, Mark Kettenis wrote: >> From: Kever Yang <kever.yang@rock-chips.com> >> Date: Sun, 7 Jun 2020 20:32:33 +0800 >> >> Hi Mark, >> >> What's the change in this new version? > No change. Just regenerated from a clean master such that there are > no conflicts when applying. Thanks, already apply to u-boot-rockchip master. Thanks, - Kever
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index 4c9f1e189b..5bb54f5835 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y CONFIG_CMD_GPT=y CONFIG_CMD_MMC=y CONFIG_CMD_USB=y +CONFIG_CMD_PCI=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y CONFIG_SPL_OF_CONTROL=y @@ -38,10 +39,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000 CONFIG_DM_ETH=y CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y +CONFIG_NVME=y +CONFIG_PCI=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYSRESET=y