diff mbox series

[v2,4/8] rockchip: puma: fix indentation of misc_init_r

Message ID 20200604100908.468659-5-heiko@sntech.de
State Superseded
Delegated to: Kever Yang
Headers show
Series revive Theobroma-Systems puma board | expand

Commit Message

Heiko Stuebner June 4, 2020, 10:09 a.m. UTC
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

The commit moving puma to the generic cpuid/macaddr helpers used 7 spaces
as indentation, so correct that by moving to the required tabs.

Fixes: fa177ff0208b ("board: puma: Use rockchip_* helpers to setup cpuid and macaddr")
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
 .../puma_rk3399/puma-rk3399.c                 | 32 +++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

Comments

Kever Yang June 5, 2020, 2:23 a.m. UTC | #1
On 2020/6/4 下午6:09, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The commit moving puma to the generic cpuid/macaddr helpers used 7 spaces
> as indentation, so correct that by moving to the required tabs.
>
> Fixes: fa177ff0208b ("board: puma: Use rockchip_* helpers to setup cpuid and macaddr")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   .../puma_rk3399/puma-rk3399.c                 | 32 +++++++++----------
>   1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
> index f7f08ae617..65bb2ad6f2 100644
> --- a/board/theobroma-systems/puma_rk3399/puma-rk3399.c
> +++ b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
> @@ -114,22 +114,22 @@ static int setup_boottargets(void)
>   
>   int misc_init_r(void)
>   {
> -       const u32 cpuid_offset = 0x7;
> -       const u32 cpuid_length = 0x10;
> -       u8 cpuid[cpuid_length];
> -       int ret;
> -
> -       ret = rockchip_cpuid_from_efuse(cpuid_offset, cpuid_length, cpuid);
> -       if (ret)
> -               return ret;
> -
> -       ret = rockchip_cpuid_set(cpuid, cpuid_length);
> -       if (ret)
> -               return ret;
> -
> -       ret = rockchip_setup_macaddr();
> -       if (ret)
> -               return ret;
> +	const u32 cpuid_offset = 0x7;
> +	const u32 cpuid_length = 0x10;
> +	u8 cpuid[cpuid_length];
> +	int ret;
> +
> +	ret = rockchip_cpuid_from_efuse(cpuid_offset, cpuid_length, cpuid);
> +	if (ret)
> +		return ret;
> +
> +	ret = rockchip_cpuid_set(cpuid, cpuid_length);
> +	if (ret)
> +		return ret;
> +
> +	ret = rockchip_setup_macaddr();
> +	if (ret)
> +		return ret;
>   
>   	setup_iodomain();
>   	setup_boottargets();
diff mbox series

Patch

diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
index f7f08ae617..65bb2ad6f2 100644
--- a/board/theobroma-systems/puma_rk3399/puma-rk3399.c
+++ b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
@@ -114,22 +114,22 @@  static int setup_boottargets(void)
 
 int misc_init_r(void)
 {
-       const u32 cpuid_offset = 0x7;
-       const u32 cpuid_length = 0x10;
-       u8 cpuid[cpuid_length];
-       int ret;
-
-       ret = rockchip_cpuid_from_efuse(cpuid_offset, cpuid_length, cpuid);
-       if (ret)
-               return ret;
-
-       ret = rockchip_cpuid_set(cpuid, cpuid_length);
-       if (ret)
-               return ret;
-
-       ret = rockchip_setup_macaddr();
-       if (ret)
-               return ret;
+	const u32 cpuid_offset = 0x7;
+	const u32 cpuid_length = 0x10;
+	u8 cpuid[cpuid_length];
+	int ret;
+
+	ret = rockchip_cpuid_from_efuse(cpuid_offset, cpuid_length, cpuid);
+	if (ret)
+		return ret;
+
+	ret = rockchip_cpuid_set(cpuid, cpuid_length);
+	if (ret)
+		return ret;
+
+	ret = rockchip_setup_macaddr();
+	if (ret)
+		return ret;
 
 	setup_iodomain();
 	setup_boottargets();