diff mbox series

[PATCHv5,3/7] board: tbs2910: move CONFIG_BOOTCOMMAND from header to defconfig

Message ID 20200530032425.10670-3-GNUtoo@cyberdimension.org
State Accepted
Commit 0c7550f03a67d9fd2b67e4c299f6d8908e2c7d5b
Delegated to: Tom Rini
Headers show
Series [PATCHv5,1/7] board: tbs2910: disable loadb and loads commands | expand

Commit Message

Denis 'GNUtoo' Carikli May 30, 2020, 3:24 a.m. UTC 
This doesn't affect the size of the image: with
arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola GNU/Linux
distribution, the text, data, bss and total sizes remain
unchanged.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Reviewed-by: Soeren Moch <smoch@web.de>
---
Changelog since v4:
-------------------
- Added the following tag:
  Acked-by: Soeren Moch <smoch@web.de>
---
 configs/tbs2910_defconfig | 2 ++
 include/configs/tbs2910.h | 8 --------
 2 files changed, 2 insertions(+), 8 deletions(-)

Comments

Tom Rini June 12, 2020, 9:17 p.m. UTC | #1 
On Sat, May 30, 2020 at 05:24:21AM +0200, Denis 'GNUtoo' Carikli wrote:

> This doesn't affect the size of the image: with
> arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola GNU/Linux
> distribution, the text, data, bss and total sizes remain
> unchanged.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> Reviewed-by: Soeren Moch <smoch@web.de>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
index cc459e6de6..d14ff45615 100644
--- a/configs/tbs2910_defconfig
+++ b/configs/tbs2910_defconfig
@@ -10,6 +10,8 @@  CONFIG_PRE_CON_BUF_ADDR=0x7c000000
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_AHCI=y
 CONFIG_BOOTDELAY=3
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="mmc rescan; if run bootcmd_up1; then run bootcmd_up2; else run bootcmd_mmc; fi"
 CONFIG_USE_PREBOOT=y
 CONFIG_PREBOOT="echo PCI:; pci enum; pci 1; usb start; if hdmidet; then run set_con_hdmi; else run set_con_serial; fi"
 CONFIG_PRE_CONSOLE_BUFFER=y
diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h
index 7376b91f55..a230111251 100644
--- a/include/configs/tbs2910.h
+++ b/include/configs/tbs2910.h
@@ -100,12 +100,4 @@ 
 	"stdin=serial,usbkbd\0" \
 	"stdout=serial,vga\0"
 
-#define CONFIG_BOOTCOMMAND \
-	"mmc rescan; " \
-	"if run bootcmd_up1; then " \
-		"run bootcmd_up2; " \
-	"else " \
-		"run bootcmd_mmc; " \
-	"fi"
-
 #endif			       /* __TBS2910_CONFIG_H * */