| Message ID | 20200528091736.40634-4-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | b9ce32ec3a0483ad4eee0f85ed2b4085fe69349a |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [v2,1/4] x86: tangier: acpi: Create buffers outside of the methods | expand |
On Thu, May 28, 2020 at 5:17 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > ACPICA complains that either _HID() or _ADR() should be used. > For General Purpose DMA we may not drop the _ADR() because > the device is enumerated by PCI. Thus, simple drop _HID(). > > Reported-by: Bin Meng <bmeng.cn@gmail.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: no changes > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Tested-by: Bin Meng <bmeng.cn@gmail.com>
On Mon, Jun 1, 2020 at 10:57 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Thu, May 28, 2020 at 5:17 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > ACPICA complains that either _HID() or _ADR() should be used. > > For General Purpose DMA we may not drop the _ADR() because > > the device is enumerated by PCI. Thus, simple drop _HID(). > > > > Reported-by: Bin Meng <bmeng.cn@gmail.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > v2: no changes > > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - > > 1 file changed, 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > Tested-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl index f9da188b38f6..df666259308d 100644 --- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl @@ -520,7 +520,6 @@ Device (PCI0) Device (GDMA) { Name (_ADR, 0x00150000) - Name (_HID, "808611A2") Name (_UID, Zero) Method (_STA, 0, NotSerialized)
ACPICA complains that either _HID() or _ADR() should be used. For General Purpose DMA we may not drop the _ADR() because the device is enumerated by PCI. Thus, simple drop _HID(). Reported-by: Bin Meng <bmeng.cn@gmail.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: no changes arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 - 1 file changed, 1 deletion(-)