diff mbox series

[v3,1/5] imx8mp_evk: spl: drop useless code

Message ID 20200526233350.25190-1-festevam@gmail.com
State Accepted
Commit 87f6e2f51e337623b1794e916d8b8eb654736c0d
Delegated to: Stefano Babic
Headers show
Series [v3,1/5] imx8mp_evk: spl: drop useless code | expand

Commit Message

Fabio Estevam May 26, 2020, 11:33 p.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Drop useless getting ccm device, there is no need to explicted do this
in board code, and we not enable SPL CLK currently.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v2:
- None. Rebased against U-Boot master

 board/freescale/imx8mp_evk/spl.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Fabio Estevam June 4, 2020, 12:09 p.m. UTC | #1 
Hi Stefano,

On Tue, May 26, 2020 at 8:34 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Drop useless getting ccm device, there is no need to explicted do this
> in board code, and we not enable SPL CLK currently.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Please consider this series for 2020.07 as it fixes the boot problem.

Thanks
Stefano Babic June 4, 2020, 12:20 p.m. UTC | #2 
On 04.06.20 14:09, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Tue, May 26, 2020 at 8:34 PM Fabio Estevam <festevam@gmail.com> wrote:
>>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Drop useless getting ccm device, there is no need to explicted do this
>> in board code, and we not enable SPL CLK currently.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> 
> Please consider this series for 2020.07 as it fixes the boot problem.
> 


Ok, thanks - I will go on through patches to check what should be pushed
to Tom.

Regards,
Stefano
Stefano Babic June 8, 2020, 5:22 p.m. UTC | #3 
> From: Peng Fan <peng.fan@nxp.com>
> Drop useless getting ccm device, there is no need to explicted do this
> in board code, and we not enable SPL CLK currently.
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/freescale/imx8mp_evk/spl.c b/board/freescale/imx8mp_evk/spl.c
index cd5b32c3f8..f2cc177757 100644
--- a/board/freescale/imx8mp_evk/spl.c
+++ b/board/freescale/imx8mp_evk/spl.c
@@ -29,11 +29,6 @@ 
 #include <mmc.h>
 #include <asm/arch/ddr.h>
 
-#include <dm/uclass.h>
-#include <dm/device.h>
-#include <dm/uclass-internal.h>
-#include <dm/device-internal.h>
-
 DECLARE_GLOBAL_DATA_PTR;
 
 int spl_board_boot_device(enum boot_device boot_dev_spl)
@@ -48,16 +43,7 @@  void spl_dram_init(void)
 
 void spl_board_init(void)
 {
-	struct udevice *dev;
-	int ret;
-
 	puts("Normal Boot\n");
-
-	ret = uclass_get_device_by_name(UCLASS_CLK,
-					"clock-controller@30380000",
-					&dev);
-	if (ret < 0)
-		printf("Failed to find clock node. Check device tree\n");
 }
 
 #define I2C_PAD_CTRL (PAD_CTL_DSE6 | PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PE)