diff mbox series

board: xilinx/zynqmp: Remove 1-second delay at boot

Message ID 20200526082026.18898-1-mike.looijmans@topic.nl
State New
Delegated to: Michal Simek
Headers show
Series board: xilinx/zynqmp: Remove 1-second delay at boot | expand

Commit Message

Mike Looijmans May 26, 2020, 8:20 a.m. UTC
SPL boot is slow on the ZynqMP because of this delay. The initialization done
in psu_init no longer requires an external delay, so this can be removed to
speed up the SPL boot flow considerably.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 board/xilinx/zynqmp/zynqmp.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Michal Simek May 29, 2020, 11:34 a.m. UTC | #1
On 26. 05. 20 10:20, Mike Looijmans wrote:
> SPL boot is slow on the ZynqMP because of this delay. The initialization done
> in psu_init no longer requires an external delay, so this can be removed to
> speed up the SPL boot flow considerably.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  board/xilinx/zynqmp/zynqmp.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
> index cb72914adb..d00235f236 100644
> --- a/board/xilinx/zynqmp/zynqmp.c
> +++ b/board/xilinx/zynqmp/zynqmp.c
> @@ -32,7 +32,6 @@
>  #include <zynqmp_firmware.h>
>  #include <g_dnl.h>
>  #include <linux/bitops.h>
> -#include <linux/delay.h>
>  #include <linux/sizes.h>
>  #include "../common/board.h"
>  
> @@ -334,9 +333,6 @@ int board_early_init_f(void)
>  	ret = psu_init();
>  	if (ret)
>  		return ret;
> -
> -	/* Delay is required for clocks to be propagated */
> -	udelay(1000000);
>  #endif
>  
>  #ifdef CONFIG_DEBUG_UART
> 

Mike reported me that removing this 1s is causing issue in SD boot mode
that's why I am not applying this patch till we root caused it.

Thanks,
Michal
diff mbox series

Patch

diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
index cb72914adb..d00235f236 100644
--- a/board/xilinx/zynqmp/zynqmp.c
+++ b/board/xilinx/zynqmp/zynqmp.c
@@ -32,7 +32,6 @@ 
 #include <zynqmp_firmware.h>
 #include <g_dnl.h>
 #include <linux/bitops.h>
-#include <linux/delay.h>
 #include <linux/sizes.h>
 #include "../common/board.h"
 
@@ -334,9 +333,6 @@  int board_early_init_f(void)
 	ret = psu_init();
 	if (ret)
 		return ret;
-
-	/* Delay is required for clocks to be propagated */
-	udelay(1000000);
 #endif
 
 #ifdef CONFIG_DEBUG_UART