| Message ID | 20200429163446.15390-3-rayagonda.kokatanur@broadcom.com |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | extend pinctrl-single driver with APIs | expand |
Hi Rayagonda, +Stephen Warren On Wed, 29 Apr 2020 at 10:35, Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> wrote: > > Parse different gpio properties from dt as part of probe > function. This detail will be used to enable pinctrl pad > later when gpio lines are requested. > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > --- > drivers/pinctrl/pinctrl-single.c | 62 +++++++++++++++++++++++++++++++- > 1 file changed, 61 insertions(+), 1 deletion(-) Can you please add the binding and a test? Also I think this feature should be behind a Kconfig flag to avoid code-size increase. Regards, Simon
Hi Simon, On Wed, Apr 29, 2020 at 11:34 PM Simon Glass <sjg@chromium.org> wrote: > > Hi Rayagonda, > > +Stephen Warren > > On Wed, 29 Apr 2020 at 10:35, Rayagonda Kokatanur > <rayagonda.kokatanur@broadcom.com> wrote: > > > > Parse different gpio properties from dt as part of probe > > function. This detail will be used to enable pinctrl pad > > later when gpio lines are requested. > > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > > --- > > drivers/pinctrl/pinctrl-single.c | 62 +++++++++++++++++++++++++++++++- > > 1 file changed, 61 insertions(+), 1 deletion(-) > > Can you please add the binding and a test? Also I think this feature > should be behind a Kconfig flag to avoid code-size increase. Sorry I didn't get it, please elaborate "binding and a test". You mean dt-binding document and test procedure. This feature is added by referring to linux pinctrl-single driver and code is in align with linux driver. This feature is going to be used in most of the gpio controllers where they have pin controllers to select different modes of gpio lines. I feel this feature should be part of the driver by default. > > Regards, > Simon
Hi Rayagonda, On Thu, 30 Apr 2020 at 05:10, Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> wrote: > > Hi Simon, > > On Wed, Apr 29, 2020 at 11:34 PM Simon Glass <sjg@chromium.org> wrote: > > > > Hi Rayagonda, > > > > +Stephen Warren > > > > On Wed, 29 Apr 2020 at 10:35, Rayagonda Kokatanur > > <rayagonda.kokatanur@broadcom.com> wrote: > > > > > > Parse different gpio properties from dt as part of probe > > > function. This detail will be used to enable pinctrl pad > > > later when gpio lines are requested. > > > > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > > > --- > > > drivers/pinctrl/pinctrl-single.c | 62 +++++++++++++++++++++++++++++++- > > > 1 file changed, 61 insertions(+), 1 deletion(-) > > > > Can you please add the binding and a test? Also I think this feature > > should be behind a Kconfig flag to avoid code-size increase. > > Sorry I didn't get it, please elaborate "binding and a test". > You mean dt-binding document and test procedure. That's right. For the tests, it seems we do not have a test/dm/pinctrl.c but we need one, something simple to start. The binding will help explain what is going on. > > This feature is added by referring to linux pinctrl-single driver and > code is in align with linux driver. > This feature is going to be used in most of the gpio controllers where > they have pin controllers to select > different modes of gpio lines. I feel this feature should be part of > the driver by default. OK makes sense. Re the Kconfig flag, U-Boot SPL runs in a tight environment. So when we add new features we sometimes put them behind a flag so that it does not bloat SPL. Regards, Simon
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index aed113b083..fe79a218ee 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -6,10 +6,26 @@ #include <common.h> #include <dm.h> #include <dm/device_compat.h> +#include <dm/devres.h> +#include <dm/of_access.h> #include <dm/pinctrl.h> #include <linux/libfdt.h> #include <asm/io.h> +/** + * struct single_gpiofunc_range - pin ranges with same mux value of gpio fun + * @offset: offset base of pins + * @npins: number pins with the same mux value of gpio function + * @gpiofunc: mux value of gpio function + * @node: list node + */ +struct single_gpiofunc_range { + u32 offset; + u32 npins; + u32 gpiofunc; + struct list_head node; +}; + /** * struct single_pdata - pinctrl device instance * @base first configuration register @@ -17,6 +33,8 @@ * @mask configuration-value mask bits * @width configuration register bit width * @bits_per_mux + * @mutex mutex protecting the list + * @gpiofuncs list of gpio functions * @read register read function to use * @write register write function to use */ @@ -26,6 +44,8 @@ struct single_pdata { u32 mask; /* configuration-value mask bits */ int width; /* configuration register bit width */ bool bits_per_mux; + struct mutex mutex; + struct list_head gpiofuncs; u32 (*read)(phys_addr_t reg); void (*write)(u32 val, phys_addr_t reg); }; @@ -171,9 +191,42 @@ static int single_set_state(struct udevice *dev, return len; } +static int single_add_gpio_func(struct udevice *dev, + struct single_pdata *pdata) +{ + const char *propname = "pinctrl-single,gpio-range"; + const char *cellname = "#pinctrl-single,gpio-range-cells"; + struct single_gpiofunc_range *range; + struct ofnode_phandle_args gpiospec; + int ret, i; + + for (i = 0; ; i++) { + ret = ofnode_parse_phandle_with_args(dev->node, propname, + cellname, 0, i, &gpiospec); + /* Do not treat it as error. Only treat it as end condition. */ + if (ret) { + ret = 0; + break; + } + range = devm_kzalloc(dev, sizeof(*range), GFP_KERNEL); + if (!range) { + ret = -ENOMEM; + break; + } + range->offset = gpiospec.args[0]; + range->npins = gpiospec.args[1]; + range->gpiofunc = gpiospec.args[2]; + mutex_lock(&pdata->mutex); + list_add_tail(&range->node, &pdata->gpiofuncs); + mutex_unlock(&pdata->mutex); + } + return ret; +} + static int single_probe(struct udevice *dev) { struct single_pdata *pdata = dev->platdata; + int ret; switch (pdata->width) { case 8: @@ -194,7 +247,14 @@ static int single_probe(struct udevice *dev) return -EINVAL; } - return 0; + mutex_init(&pdata->mutex); + INIT_LIST_HEAD(&pdata->gpiofuncs); + + ret = single_add_gpio_func(dev, pdata); + if (ret < 0) + dev_err(dev, "%s: Failed to add gpio functions\n", __func__); + + return ret; } static int single_ofdata_to_platdata(struct udevice *dev)
Parse different gpio properties from dt as part of probe function. This detail will be used to enable pinctrl pad later when gpio lines are requested. Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> --- drivers/pinctrl/pinctrl-single.c | 62 +++++++++++++++++++++++++++++++- 1 file changed, 61 insertions(+), 1 deletion(-)