diff mbox series

[v2,1/7] spl: fit: select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE

Message ID 20200421002333.111461-2-heiko@sntech.de
State Accepted
Delegated to: Kever Yang
Headers show
Series rockchip: make it possible to sign the u-boot.itb | expand

Commit Message

Heiko Stuebner April 21, 2020, 12:23 a.m. UTC 
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

rsa-checsum needs support for hash functions or else will run into
compile errors like:
u-boot/lib/rsa/rsa-checksum.c:28: undefined reference to `hash_progressive_lookup_algo'

So similar to the main FIT_SIGNATURE entry selects HASH,
select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE.

Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
 Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kever Yang April 28, 2020, 1:45 p.m. UTC | #1 
On 2020/4/21 上午8:23, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> rsa-checsum needs support for hash functions or else will run into
> compile errors like:
> u-boot/lib/rsa/rsa-checksum.c:28: undefined reference to `hash_progressive_lookup_algo'
>
> So similar to the main FIT_SIGNATURE entry selects HASH,
> select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE.
>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Kconfig b/Kconfig
> index 1b0b6999d8..2b84402baa 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -445,6 +445,7 @@ config SPL_FIT_SIGNATURE
>   	bool "Enable signature verification of FIT firmware within SPL"
>   	depends on SPL_DM
>   	select SPL_FIT
> +	select SPL_HASH_SUPPORT
>   	select SPL_RSA
>   	select SPL_RSA_VERIFY
>   	select IMAGE_SIGN_INFO
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index 1b0b6999d8..2b84402baa 100644
--- a/Kconfig
+++ b/Kconfig
@@ -445,6 +445,7 @@  config SPL_FIT_SIGNATURE
 	bool "Enable signature verification of FIT firmware within SPL"
 	depends on SPL_DM
 	select SPL_FIT
+	select SPL_HASH_SUPPORT
 	select SPL_RSA
 	select SPL_RSA_VERIFY
 	select IMAGE_SIGN_INFO