diff mbox series

[v2,7/7] ddr: altera: arria10: Remove call to dram_init_banksize()

Message ID 20200420084624.110026-8-ley.foon.tan@intel.com
State New
Delegated to: Simon Goldschmidt
Headers show
Series ddr: altera: arria10: Convert SDRAM driver to DM | expand

Commit Message

Tan, Ley Foon April 20, 2020, 8:46 a.m. UTC
dram_init_banksize() is called in board_init_f() boot sequences
in Uboot, remove it from SDRAM driver.

Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
 drivers/ddr/altera/sdram_arria10.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Ley Foon Tan April 30, 2020, 11:02 a.m. UTC | #1
On Mon, Apr 20, 2020 at 4:46 PM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>
> dram_init_banksize() is called in board_init_f() boot sequences
> in Uboot, remove it from SDRAM driver.
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>  drivers/ddr/altera/sdram_arria10.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c
> index e4944ef95183..27fd393e6fe4 100644
> --- a/drivers/ddr/altera/sdram_arria10.c
> +++ b/drivers/ddr/altera/sdram_arria10.c
> @@ -660,9 +660,6 @@ static int ddr_calibration_sequence(struct altera_sdram_platdata *plat)
>         else
>                 gd->ram_size = (u32)size;
>
> -       /* setup the dram info within bd */
> -       dram_init_banksize();
> -
>         if (of_sdram_firewall_setup(gd->fdt_blob))
>                 puts("FW: Error Configuring Firewall\n");
>
Hi

Need to drop this patch, Found that dcache_enable() needs gd->bd->bi_dram[].
I will send v3.

Thanks.

Regards
Ley Foon
Marek Vasut April 30, 2020, 11:04 a.m. UTC | #2
On 4/30/20 1:02 PM, Ley Foon Tan wrote:
> On Mon, Apr 20, 2020 at 4:46 PM Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>>
>> dram_init_banksize() is called in board_init_f() boot sequences
>> in Uboot, remove it from SDRAM driver.
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> ---
>>  drivers/ddr/altera/sdram_arria10.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c
>> index e4944ef95183..27fd393e6fe4 100644
>> --- a/drivers/ddr/altera/sdram_arria10.c
>> +++ b/drivers/ddr/altera/sdram_arria10.c
>> @@ -660,9 +660,6 @@ static int ddr_calibration_sequence(struct altera_sdram_platdata *plat)
>>         else
>>                 gd->ram_size = (u32)size;
>>
>> -       /* setup the dram info within bd */
>> -       dram_init_banksize();
>> -
>>         if (of_sdram_firewall_setup(gd->fdt_blob))
>>                 puts("FW: Error Configuring Firewall\n");
>>
> Hi
> 
> Need to drop this patch, Found that dcache_enable() needs gd->bd->bi_dram[].
> I will send v3.

OK, thanks.
diff mbox series

Patch

diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c
index e4944ef95183..27fd393e6fe4 100644
--- a/drivers/ddr/altera/sdram_arria10.c
+++ b/drivers/ddr/altera/sdram_arria10.c
@@ -660,9 +660,6 @@  static int ddr_calibration_sequence(struct altera_sdram_platdata *plat)
 	else
 		gd->ram_size = (u32)size;
 
-	/* setup the dram info within bd */
-	dram_init_banksize();
-
 	if (of_sdram_firewall_setup(gd->fdt_blob))
 		puts("FW: Error Configuring Firewall\n");