diff mbox series

[RESEND,v5,2/6] fdtdec: Fix boundary check

Message ID 20200418060758.4839-3-atish.patra@wdc.com
State Superseded
Delegated to: Andes
Headers show
Series RISC-V DT related fixes for reserved memory & UEFI | expand

Commit Message

Atish Patra April 18, 2020, 6:07 a.m. UTC 
In U-Boot, the reserved memory end address is considered as a inclusive
address. This notion is followed while adding a reserved memory node to
the DT.

For example:
end_address = start_address + size - 1

Follow the same notion and fix the end address computation while checking
for existing nodes.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
---
 lib/fdtdec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bin Meng April 18, 2020, 12:24 p.m. UTC | #1 
On Sat, Apr 18, 2020 at 2:10 PM Atish Patra <atish.patra@wdc.com> wrote:
>
> In U-Boot, the reserved memory end address is considered as a inclusive
> address. This notion is followed while adding a reserved memory node to
> the DT.
>
> For example:
> end_address = start_address + size - 1
>
> Follow the same notion and fix the end address computation while checking
> for existing nodes.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> ---
>  lib/fdtdec.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index eb11fc898e30..07ba9f5c97e9 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -1311,7 +1311,8 @@  int fdtdec_add_reserved_memory(void *blob, const char *basename,
 			continue;
 		}
 
-		if (addr == carveout->start && (addr + size) == carveout->end) {
+		if (addr == carveout->start && (addr + size - 1) ==
+						carveout->end) {
 			if (phandlep)
 				*phandlep = fdt_get_phandle(blob, node);
 			return 0;