| Message ID | 20200410191347.1.If78ae0e92c7e52f0fc20716ccfbf7d5005f38a51@changeid |
|---|---|
| State | Accepted |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | board: stm32mp1: correct CONFIG_IS_ENABLED usage for LED | expand |
On 4/10/20 7:14 PM, Patrick Delaunay wrote: > Use the correct macro to test presence CONFIG_LED: > replace CONFIG_IS_ENABLED(CONFIG_LED) by CONFIG_IS_ENABLED(LED) > > Issue see during review unrelated patch > "board: stm32mp1: update management of boot-led" > http://patchwork.ozlabs.org/patch/1264823/ > > Cc: Marek Vasut <marex@denx.de> > Cc: Patrice Chotard <patrice.chotard@st.com> > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> Reviewed-by: Marek Vasut <marex@denx.de>
Hi On 4/10/20 7:14 PM, Patrick Delaunay wrote: > Use the correct macro to test presence CONFIG_LED: > replace CONFIG_IS_ENABLED(CONFIG_LED) by CONFIG_IS_ENABLED(LED) > > Issue see during review unrelated patch > "board: stm32mp1: update management of boot-led" > http://patchwork.ozlabs.org/patch/1264823/ > > Cc: Marek Vasut <marex@denx.de> > Cc: Patrice Chotard <patrice.chotard@st.com> > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > board/dhelectronics/dh_stm32mp1/board.c | 2 +- > board/st/stm32mp1/stm32mp1.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c > index 7bcd713a86..3c14d8206d 100644 > --- a/board/dhelectronics/dh_stm32mp1/board.c > +++ b/board/dhelectronics/dh_stm32mp1/board.c > @@ -398,7 +398,7 @@ int board_init(void) > > sysconf_init(); > > - if (CONFIG_IS_ENABLED(CONFIG_LED)) > + if (CONFIG_IS_ENABLED(LED)) > led_default_state(); > > return 0; > diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c > index 07f5344ec9..053c5e1f07 100644 > --- a/board/st/stm32mp1/stm32mp1.c > +++ b/board/st/stm32mp1/stm32mp1.c > @@ -647,7 +647,7 @@ int board_init(void) > > sysconf_init(); > > - if (CONFIG_IS_ENABLED(CONFIG_LED)) > + if (CONFIG_IS_ENABLED(LED)) > led_default_state(); > > return 0; Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks Patrice
Hi On 4/14/20 2:53 PM, Patrice CHOTARD wrote: > Hi > > On 4/10/20 7:14 PM, Patrick Delaunay wrote: >> Use the correct macro to test presence CONFIG_LED: >> replace CONFIG_IS_ENABLED(CONFIG_LED) by CONFIG_IS_ENABLED(LED) >> >> Issue see during review unrelated patch >> "board: stm32mp1: update management of boot-led" >> http://patchwork.ozlabs.org/patch/1264823/ >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Patrice Chotard <patrice.chotard@st.com> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> >> --- >> >> board/dhelectronics/dh_stm32mp1/board.c | 2 +- >> board/st/stm32mp1/stm32mp1.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c >> index 7bcd713a86..3c14d8206d 100644 >> --- a/board/dhelectronics/dh_stm32mp1/board.c >> +++ b/board/dhelectronics/dh_stm32mp1/board.c >> @@ -398,7 +398,7 @@ int board_init(void) >> >> sysconf_init(); >> >> - if (CONFIG_IS_ENABLED(CONFIG_LED)) >> + if (CONFIG_IS_ENABLED(LED)) >> led_default_state(); >> >> return 0; >> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c >> index 07f5344ec9..053c5e1f07 100644 >> --- a/board/st/stm32mp1/stm32mp1.c >> +++ b/board/st/stm32mp1/stm32mp1.c >> @@ -647,7 +647,7 @@ int board_init(void) >> >> sysconf_init(); >> >> - if (CONFIG_IS_ENABLED(CONFIG_LED)) >> + if (CONFIG_IS_ENABLED(LED)) >> led_default_state(); >> >> return 0; > Reviewed-by: Patrice Chotard <patrice.chotard@st.com> > > Thanks > > Patrice Applied to u-boot-stm/next Thanks Patrice > _______________________________________________ > Uboot-stm32 mailing list > Uboot-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32
diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c index 7bcd713a86..3c14d8206d 100644 --- a/board/dhelectronics/dh_stm32mp1/board.c +++ b/board/dhelectronics/dh_stm32mp1/board.c @@ -398,7 +398,7 @@ int board_init(void) sysconf_init(); - if (CONFIG_IS_ENABLED(CONFIG_LED)) + if (CONFIG_IS_ENABLED(LED)) led_default_state(); return 0; diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c index 07f5344ec9..053c5e1f07 100644 --- a/board/st/stm32mp1/stm32mp1.c +++ b/board/st/stm32mp1/stm32mp1.c @@ -647,7 +647,7 @@ int board_init(void) sysconf_init(); - if (CONFIG_IS_ENABLED(CONFIG_LED)) + if (CONFIG_IS_ENABLED(LED)) led_default_state(); return 0;
Use the correct macro to test presence CONFIG_LED: replace CONFIG_IS_ENABLED(CONFIG_LED) by CONFIG_IS_ENABLED(LED) Issue see during review unrelated patch "board: stm32mp1: update management of boot-led" http://patchwork.ozlabs.org/patch/1264823/ Cc: Marek Vasut <marex@denx.de> Cc: Patrice Chotard <patrice.chotard@st.com> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- board/dhelectronics/dh_stm32mp1/board.c | 2 +- board/st/stm32mp1/stm32mp1.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)